Notifications: all buttons exit app when no notifications#910
Open
MrXANA91 wants to merge 1 commit intocoredevices:mainfrom
Open
Notifications: all buttons exit app when no notifications#910MrXANA91 wants to merge 1 commit intocoredevices:mainfrom
MrXANA91 wants to merge 1 commit intocoredevices:mainfrom
Conversation
Member
|
what if notification is received while in? |
Contributor
Author
Tested right now, blank screen. Back to draft. |
Signed-off-by: Paul Chanvin <paul@paulchanvin.fr>
MrXANA91
force-pushed
the
autoExitNotificationsApp
branch
from
ffe913d to
da16170
Compare
Contributor
Author
|
Fixed! Better implementation and no blank screen bug when receiving a notification while being in the notification app. Ready to review |
Collaborator
|
sorry no plans to merge this. We want the buttons to act consistently. Left button - go back. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to close #570
When nothing is displayed in the Notifications app except the "No notifications" text, all buttons exit the app, not only the back button.
This does not apply if there is at least one notification.
Edit: tested on QEMU emulator and on a Pebble 2 Duo