Fix GA domain handling, GitHub URL validation, and build analytics event dispatch#11
Merged
ericmigi merged 2 commits intocoredevices:mainfrom Mar 2, 2026
Merged
Conversation
The GA tracker was configured with the wrong fixed domain. Use GA 'auto' domain resolution and skip tracking on localhost/127.0.0.1/::1 to avoid polluting production analytics.
Fix the GitHub repo input `pattern` used by the project settings UI.
`[\w.-]` can fail under browser `/v` pattern parsing because `-` is not escaped in the character class. Change it to `[\w.\-]` so UI validation works consistently without changing intended accepted characters.
Fix the unreachable statement in `compile.js` that prevented the build-run analytics event from firing. The `ga('send', ...)` call was after `return Ajax.Post(...)`; move it before the return so the event is sent again.
Contributor
|
Did you actually run into a bug that caused this or is this just a general clean-up? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes three small issues in GA tracking and GitHub repo URL validation.
Why this change
/vpattern parsing.return(unreachable code).What changed
'auto'domain resolution.localhost,127.0.0.1, and::1to match previous behavior.-in character classes:[\w.-]->[\w.\-]ga('send', 'event', 'build', 'run', ...)beforereturn Ajax.Post(...)inrun_build().Result