B13 Coverage w/ Fixes to Some Handling of Subnorms#110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
B13: @AngelaZzzzz check out this coverage when you have the chance. Let me know if there is anything you think should change. The one note that I have for you is that I do not believe
d=-1is an impossible case form-1leading zeros (as0b11 - 0b10 = 0b01, I'm not sure if there was another reason for this, so correct me if I'm wrong). Currently, when placing a try-except around the code that is throwing an error, this is giving a result of 96% coverage.Subnormal Handling: In coverfloat.cpp, the handling of trivial rounding results for subnormals was incorrect in its handling of the exponents. Now we correctly label the exponent (and in the F32 case, actually report rounding info).