More utilities for cover-float integration into act4#112
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds utility features to the cover-float test generation workflow to better support integration/build usage (e.g., avoiding redundant regeneration, providing quiet modes, and supporting a processed-vectors-only output mode).
Changes:
- Add incremental “skip regeneration” behavior for model outputs (and mark partial-output files) in testgen.
- Add
--quiet/-qlevels and--only-processed-vectorsCLI support, plus Makefile plumbing for these modes. - Reduce output generation in “processed-only” mode by suppressing covervector/readable-vector writes.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/cover_float/testgen/model.py | Adds partial-output marker, introduces regeneration skipping based on mtimes/headers, and routes covervector output to devnull in RELEASE mode. |
| src/cover_float/scripts/postprocess.py | Skips writing readable vectors in RELEASE mode while still generating processed CSVs. |
| src/cover_float/reference/impl.py | Skips writing cover vectors to the cover output file in RELEASE mode. |
| src/cover_float/common/log.py | Adds support for disabling progress rendering and suppressing progress updates based on logging level; adjusts exception logging call. |
| src/cover_float/common/constants.py | Extends global Config (bool FULL_COVERAGE_TESTGEN, QUIET, RELEASE). |
| src/cover_float/cli.py | Adds --quiet/-q and --only-processed-vectors, adjusts logging config, and tracks/skips model futures when no work is needed. |
| Makefile | Adds PROCESSED_ONLY/SILENT flags, a processed-tests-only target, and expands clean to remove generated vector artifacts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+128
to
+132
| cv_path = output_dir / "covervectors" / f"{model_name}_cv.txt" | ||
| cv_mod_time = cv_path.stat().st_mtime if cv_path.exists() else 0 | ||
|
|
||
| source_mod_time = source_file.stat().st_mtime | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Should be much better now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lots of useful features here