Skip to content

B19#79

Open
sww0000 wants to merge 12 commits into
coreyqh:mainfrom
sww0000:B19
Open

B19#79
sww0000 wants to merge 12 commits into
coreyqh:mainfrom
sww0000:B19

Conversation

@sww0000
Copy link
Copy Markdown
Contributor

@sww0000 sww0000 commented Apr 7, 2026

Finished B19 documentation and implemented B19.py

sww0000 added 6 commits April 1, 2026 20:32
- Implement B19.py with all 7 test cases (Cases 1-5, 7, 9)
- Generate 8200 test vectors per spec (328 per format×op)
- Support all 5 comparison/min-max operations
- Support all 5 floating-point formats (BF16, FP16, FP32, FP64, FP128)
- Add comprehensive B19.adoc documentation with all case tables
- Correct for Python 3.9 compatibility (avoid type union syntax)

Made-with: Cursor
Made-with: Cursor
- Implement B19 test generator covering all 7 case pairs (Normal×Normal,
  Normal×SubNormal, SubNormal×Normal, SubNormal×SubNormal, Zero×Normal,
  Normal×Zero, Zero×Zero) with 4 sign combinations each (100 vectors per
  format×op, 2500 grand total)
- Use seeded random via reproducible_hash for any_frac and any_exp values
- Update docs/B19.adoc with revised definitions, case tables, and test
  count breakdown (removed fixed anchor tables, updated to randomized model)
- Enable COVER_B19 in config.svh

Made-with: Cursor
@coreyqh
Copy link
Copy Markdown
Owner

coreyqh commented Apr 8, 2026

Good documentation!

I can merge this once merge conflicts are sorted out

@coreyqh
Copy link
Copy Markdown
Owner

coreyqh commented Apr 9, 2026

Would it be possible to have more randomness in the test cases? I understand that doing all 1s/0s is a convenient way of making values relatively greater/lesser than another, but I think it would be more robust to also have cases that are not as restricted. Same thing with using min/max norm exponents as so on.

@coreyqh
Copy link
Copy Markdown
Owner

coreyqh commented Apr 9, 2026

Also, case numbers are not sequential in the docs. Looks like 1, 2, 3, 4, 5, 7, 9. I think you are missing combinations of zero and subnorms...

sww0000 added 3 commits April 9, 2026 12:14
- Rename Case 7 to Case 6 (Normal × Zero)
- Add Case 7: Zero × Subnormal (1 cell × 4 sign combos = 4 tests)
- Add Case 8: Subnormal × Zero (1 cell × 4 sign combos = 4 tests)
- Update test count from 100 to 108 per format/operation
- Update total from 2500 to 2700 test vectors
- Implement test generation logic for new cases in B19.py

Made-with: Cursor
… and 7,8), and changed adoc accordingly

Made-with: Cursor
@coreyqh
Copy link
Copy Markdown
Owner

coreyqh commented Apr 15, 2026

I'd really like to merge this. You have a merge conflict with the makefile and you commited changes to config.svh and possibly the covergroup? Please pull the latest coverage changes and restore the config file so we can get this published!

@sww0000
Copy link
Copy Markdown
Contributor Author

sww0000 commented Apr 21, 2026

Commit 4532baf on Apr 18, 2026 is accidental. I was tryna check coverage w/ different versions of B19.svh

@coreyqh
Copy link
Copy Markdown
Owner

coreyqh commented Apr 22, 2026

I am going to leave this open until #87 is addressed. Did you mean to check in the 2nd version of the coverage?

@sww0000
Copy link
Copy Markdown
Contributor Author

sww0000 commented Apr 22, 2026

B19-2.svh is unintentional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants