[codex] fix Japanese language key labels#86
Merged
Conversation
🚀 Cloudflare Workers PreviewPreview URL: https://25472e0c-dya-studio.cormoran707.workers.dev Deployed from commit e6cdc05 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Japanese display labels and search aliases for
LANG1andLANG2.Root Cause
The Japanese layout override mapped
0x90to英数and0x91toかな, but those labels were reversed for the layout display. The searchable aliases had the same mismatch, soKANA/JAandEISU/ENresolved to the opposite language keys.Validation
npm test -- keycodes.test.ts keyboardLayouts.test.ts --runInBandnpm run lintnpm run format:checknpm run build