Add PMW3610 driver advanced settings to Trackball tab#89
Merged
Conversation
Adds a collapsible "Advanced (PMW3610 Sensor Driver)" section to the Trackball page, exposing the settings registered by cormoran/zmk-driver-pmw3610-with-custom-studio-rpc (cpi, axis swap/invert, downshift/sample timers, report interval, etc.) via the existing generic custom_settings RPC. Frame capture/streaming is a separate RPC subsystem and is intentionally not surfaced here. Extracts the per-subsystem settings card from AdvancedSettingsSection into a reusable CustomSettingsSectionCard component so both the Settings page and the new Trackball section share the same editors (int32/bool/range constraints, save/discard/reset). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
🚀 Cloudflare Workers PreviewPreview URL: https://52fd429a-dya-studio.cormoran707.workers.dev Deployed from commit 8fcccfa |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cpi, axis swap/invert, force-awake, smart algorithm, downshift/sample timers, min report interval) via the same genericcormoran.zmk.custom_settingsRPC the app already supports.AdvancedSettingsSectioninto a reusableCustomSettingsSectionCardcomponent so both the existing Settings page and the new Trackball section share the same editors (int32/bool/range-constrained fields, save/discard/reset), instead of duplicating that logic.Test plan
tsc --noEmiteslintprettier --check🤖 Generated with Claude Code