Skip to content

Fixes #54 by adding support for a couple extra attributes #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bbbco wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixes #54 by adding support for a couple extra attributes #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions htmlindex/attributes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,17 +32,21 @@ const (
BackgroundAttribute = "background"
HrefAttribute = "href"

DataSrcAttribute = "data-src"
SrcAttribute = "src"
DataSrcAttribute = "data-src"
SrcAttribute = "src"
DataImageAttribute = "data-image"

DataSrcSetAttribute = "data-srcset"
SrcSetAttribute = "srcset"

DataUrlAttribute = "data-url"
)

// nolint: revive
const (
ATag = "a"
BodyTag = "body"
DivTag = "div"
ImgTag = "img"
LinkTag = "link"
ScriptTag = "script"
Expand All @@ -57,8 +61,11 @@ var Nodes = map[string]Node{
BodyTag: {
Attributes: []string{BackgroundAttribute},
},
DivTag: {
Attributes: []string{DataUrlAttribute},
},
ImgTag: {
Attributes: []string{SrcAttribute, DataSrcAttribute, SrcSetAttribute, DataSrcSetAttribute},
Attributes: []string{SrcAttribute, DataSrcAttribute, SrcSetAttribute, DataSrcSetAttribute, DataImageAttribute},
parser: srcSetValueSplitter,
},
LinkTag: {
Expand Down
5 changes: 4 additions & 1 deletion htmlindex/htmlindex.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,11 @@ func srcSetValueSplitter(data nodeAttributeParserData) ([]string, bool) {

for i, value := range values {
value = strings.TrimSpace(value)
// remove extra query param arguments that sometimes remain attached
value = strings.Split(value, "?")[0]
// remove the width in pixels after the url
values[i], _, _ = strings.Cut(value, " ")
value, _, _ = strings.Cut(value, " ")
values[i] = value
}

return values, true
Expand Down
1 change: 1 addition & 0 deletions scraper/download.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ var tagsWithReferences = []string{
htmlindex.ScriptTag,
htmlindex.BodyTag,
htmlindex.StyleTag,
htmlindex.DivTag,
}

func (s *Scraper) downloadReferences(ctx context.Context, index *htmlindex.Index) error {
Expand Down
Loading