fixes for issue #62

.github/workflows/build-openjpeg.yml

@@ -0,0 +1,115 @@
+name: Build OpenJPEG WASM
+
+on:
+  push:
+    branches: [main]
+    paths:
+      - 'packages/openjpeg/src/**'
+      - 'packages/openjpeg/CMakeLists.txt'
+      - 'packages/openjpeg/build.sh'
+      - 'packages/openjpeg/extern/**'
+      - '.github/workflows/build-openjpeg.yml'
+  workflow_dispatch:
+
+env:
+  FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true
+
+jobs:
+  build-wasm:
+    name: Build WASM with Emscripten
+    runs-on: ubuntu-latest
+
+    permissions:
+      contents: write
+
+    steps:
+      - name: Checkout repo (with submodules)
+        uses: actions/checkout@v4
+        with:
+          submodules: recursive
+          fetch-depth: 0
+          token: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: Init git submodules
+        working-directory: packages/openjpeg
+        run: git submodule update --init --recursive
+
+      - name: Set up Emscripten SDK
+        uses: mymindstorm/setup-emsdk@v14
+        with:
+          version: 3.1.44
+          actions-cache-folder: '.emsdk-cache'
+
+      - name: Verify emcc
+        run: emcc --version
+
+      - name: Build openjpeg WASM
+        working-directory: packages/openjpeg
+        run: |
+          set -e
+          rm -rf build
+          mkdir -p build
+          mkdir -p dist
+
+          echo "~~~ CONFIGURE #1 (first run may fail - expected) ~~~"
+          (cd build && emcmake cmake .. || true)
+
+          echo "~~~ CONFIGURE #2 ~~~"
+          (cd build && emcmake cmake ..)
+
+          echo "~~~ MAKE ~~~"
+          (cd build && emmake make VERBOSE=1 -j4)
+
+          echo "~~~ BUILD tree ~~~"
+          ls -lh build/extern/openjpeg/bin/ || echo "WARNING: build/extern/openjpeg/bin/ not found"
+
+          echo "~~~ COPY artifacts from build/extern/openjpeg/bin/ ~~~"
+          cp ./build/extern/openjpeg/bin/openjpegjs.js            ./dist/
+          cp ./build/extern/openjpeg/bin/openjpegjs.js.mem        ./dist/ 2>/dev/null || true
+          cp ./build/extern/openjpeg/bin/openjpegwasm.js          ./dist/
+          cp ./build/extern/openjpeg/bin/openjpegwasm.wasm        ./dist/
+          cp ./build/extern/openjpeg/bin/openjpegjs_decode.js     ./dist/
+          cp ./build/extern/openjpeg/bin/openjpegjs_decode.js.mem ./dist/ 2>/dev/null || true
+          cp ./build/extern/openjpeg/bin/openjpegwasm_decode.js   ./dist/
+          cp ./build/extern/openjpeg/bin/openjpegwasm_decode.wasm ./dist/
+
+          echo "~~~ DIST contents ~~~"
+          ls -lh dist/
+
+          test -f dist/openjpegwasm_decode.js   || (echo "FATAL: openjpegwasm_decode.js missing" && exit 1)
+          test -f dist/openjpegwasm_decode.wasm || (echo "FATAL: openjpegwasm_decode.wasm missing" && exit 1)
+
+      - name: Upload dist as artifact
+        uses: actions/upload-artifact@v4
+        with:
+          name: openjpeg-wasm-dist
+          path: packages/openjpeg/dist/
+          if-no-files-found: error
+          retention-days: 30
+
+      - name: Commit dist artifacts back to repo
+        run: |
+          git config user.name  "github-actions[bot]"
+          git config user.email "github-actions[bot]@users.noreply.github.com"
+          # Ensure push uses the authenticated GITHUB_TOKEN URL
+          git remote set-url origin https://x-access-token:${{ secrets.GITHUB_TOKEN }}@github.com/${{ github.repository }}
+          git add -f packages/openjpeg/dist/
+          if git diff --cached --quiet; then
+            echo "No changes to dist - skipping commit."
+          else
+            git commit -m "ci: update openjpeg WASM dist artifacts [skip ci]"
+            git push origin main
+          fi
+
+      - name: Trigger cornerstoneWADOImageLoader migration
+        if: success()
+        uses: peter-evans/repository-dispatch@v3
+        with:
+          token: ${{ secrets.CROSS_REPO_PAT }}
+          repository: ahmedezzat85/cornerstoneWADOImageLoader
+          event-type: openjpeg-wasm-updated
+          client-payload: |
+            {
+              "codecs_sha": "${{ github.sha }}",
+              "run_id": "${{ github.run_id }}"
+            }

packages/openjpeg/.gitignore

@@ -1,12 +1,3 @@
-build/*
-build-native/*
-dist/*
-!build/.gitpreserve
-!build-native/.gitpreserve
-!dist/.gitpreserve
-
-# TEST
-test/fixtures/MG1.JLS
-test/fixtures/artificial*
-OpenJPH
-node_modules/*
+build/
+node_modules/
+# dist/ is intentionally NOT ignored — CI commits build artifacts here

packages/openjpeg/dist/.gitkeep

@@ -0,0 +1,2 @@
+# This file ensures the dist/ directory is tracked by git.
+# Actual build artifacts (*.js, *.wasm) are committed here by CI.

packages/openjpeg/src/CMakeLists.txt

@@ -25,10 +25,12 @@ set_target_properties(
       -s MODULARIZE=1 \
       -s EXPORT_NAME=OpenJPEGJS \
       -s WASM=0 \
-      -s DISABLE_EXCEPTION_CATCHING=1 \
-      -s ASSERTIONS=0 \
+      -s DISABLE_EXCEPTION_CATCHING=0 \
+      -s ASSERTIONS=1 \
       -s NO_EXIT_RUNTIME=1 \
       -s ALLOW_MEMORY_GROWTH=1 \
+      -s ALLOW_TABLE_GROWTH=1 \
+      -s EMULATE_FUNCTION_POINTER_CASTS=1 \
       -s INITIAL_MEMORY=50mb \
       -s FILESYSTEM=0 \
       -s EXPORTED_FUNCTIONS=[] \
@@ -61,10 +63,12 @@ set_target_properties(
          --bind \
          -s MODULARIZE=1 \
          -s EXPORT_NAME=OpenJPEGWASM \
-         -s DISABLE_EXCEPTION_CATCHING=1 \
-         -s ASSERTIONS=0 \
+         -s DISABLE_EXCEPTION_CATCHING=0 \
+         -s ASSERTIONS=1 \
          -s NO_EXIT_RUNTIME=1 \
          -s ALLOW_MEMORY_GROWTH=1 \
+         -s ALLOW_TABLE_GROWTH=1 \
+         -s EMULATE_FUNCTION_POINTER_CASTS=1 \
 	       -s INITIAL_MEMORY=50mb \
          -s FILESYSTEM=0 \
          -s EXPORTED_FUNCTIONS=[] \
@@ -99,10 +103,12 @@ set_target_properties(
       -s MODULARIZE=1 \
       -s EXPORT_NAME=OpenJPEGJS \
       -s WASM=0 \
-      -s DISABLE_EXCEPTION_CATCHING=1 \
-      -s ASSERTIONS=0 \
+      -s DISABLE_EXCEPTION_CATCHING=0 \
+      -s ASSERTIONS=1 \
       -s NO_EXIT_RUNTIME=1 \
       -s ALLOW_MEMORY_GROWTH=1 \
+      -s ALLOW_TABLE_GROWTH=1 \
+      -s EMULATE_FUNCTION_POINTER_CASTS=1 \
       -s INITIAL_MEMORY=50mb  \
       -s FILESYSTEM=0 \
       -s EXPORTED_FUNCTIONS=[] \
@@ -127,21 +133,21 @@ set_target_properties(
    include_directories("../extern/openjpeg/src/lib/openjp2" "../build/extern/openjpeg/src/lib/openjp2"
                     "../extern/openjpeg/src/bin/common" "../build/extern/openjpeg/src/bin/common")
 
-
    set_target_properties(
     openjpegwasm_decode
        PROPERTIES
        LINK_FLAGS "\
          --bind \
          -s MODULARIZE=1 \
          -s EXPORT_NAME=OpenJPEGWASM \
-         -s DISABLE_EXCEPTION_CATCHING=1 \
-         -s ASSERTIONS=0 \
+         -s DISABLE_EXCEPTION_CATCHING=0 \
+         -s ASSERTIONS=1 \
          -s NO_EXIT_RUNTIME=1 \
          -s ALLOW_MEMORY_GROWTH=1 \
+         -s ALLOW_TABLE_GROWTH=1 \
+         -s EMULATE_FUNCTION_POINTER_CASTS=1 \
 	       -s INITIAL_MEMORY=50mb \
          -s FILESYSTEM=0 \
          -s EXPORTED_FUNCTIONS=[] \
          -s EXPORTED_RUNTIME_METHODS=[ccall] \
       ")
-