Open
Conversation
Ragnar-Oock
reviewed
Jul 10, 2025
| dataOffset: element.dataOffset, | ||
| length : element.length | ||
| }; | ||
| result[tag] = dicomParser.explicitElementToString(dataSet, element); |
There was a problem hiding this comment.
This will create entries with undefined values in result, which could break client code enumerating on said result, this if rewrite is an API change.
Comment on lines
+79
to
80
| element = null; | ||
| return; |
There was a problem hiding this comment.
This clean-up is not needed as the whole closure is disposed of with the return statement that follows.
| } | ||
| } | ||
|
|
||
| delete element.tag; |
There was a problem hiding this comment.
Why delete the tag property of the last parsed element?
Comment on lines
+40
to
+46
| element = null; | ||
| return; | ||
| } | ||
| } | ||
|
|
||
| delete element.tag; | ||
|
|
There was a problem hiding this comment.
same comments as in parseDicomDataSetImplicit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several tweaks to speed up freeing of memory in heap and overall performance. From my testing I got about a 4% improvement.