Release: first-class People and Company links (KAN-278), person archive, job-create fixes

.env.example

@@ -43,9 +43,9 @@ DJANGO_SITE_DOMAIN=your-domain.ngrok-free.app
 
 # Xero Integration
 XERO_DEFAULT_USER_ID=YOUR_XERO_USER_ID_FOR_TIME_ENTRIES
-XERO_SYNC_PROJECTS=False
 # Suppress all Xero writes for this process (E2E/test backends only; reads stay live)
 XERO_READONLY=False
+XERO_SYNC_PROJECTS=False
 
 # JWT Configuration
 ENABLE_JWT_AUTH=True

.env.precommit

@@ -16,8 +16,8 @@ REDIS_HOST=localhost
 REDIS_PORT=6379
 XERO_CLIENT_ID=dummy
 XERO_CLIENT_SECRET=dummy
-XERO_REDIRECT_URI=http://localhost
 XERO_DEFAULT_USER_ID=dummy
+XERO_REDIRECT_URI=http://localhost
 EMAIL_HOST=localhost
 EMAIL_PORT=587
 EMAIL_USE_TLS=false
@@ -33,8 +33,8 @@ SKIP_VERSION_CHECK=True
 ALLOWED_HOSTS=localhost,127.0.0.1
 DJANGO_SITE_DOMAIN=localhost
 APP_DOMAIN=localhost
-XERO_SYNC_PROJECTS=False
 XERO_READONLY=False
+XERO_SYNC_PROJECTS=False
 XERO_WEBHOOK_KEY=dummy-webhook-key
 CORS_ALLOWED_ORIGINS=http://localhost:3000
 ENABLE_JWT_AUTH=False

.vscode/tasks.json

@@ -120,7 +120,7 @@
       }
     },
     {
-      "label": "Start Hotfix Environment",
+      "label": "Start Dev Environment",
       "dependsOn": [
         "Frontend Dev Server",
         "Frontend Manual Dev Server",

CLAUDE.md

@@ -25,6 +25,10 @@ Examples:
 - If asked whether a bug is fixed, verify the behavior that matters to the user, not only that a unit test passed.
 - If asked to review a proposal, assess whether it solves the problem and what risks remain, not only whether the text is internally consistent.
 
+## No feature removal
+
+Replacing or rewriting any component, page, model, or endpoint requires a **Feature Parity Inventory** first: enumerate every capability the old version exposed (buttons, actions, fields, shortcuts, edge cases — sourced from its template/emits, its tests, E2E specs, ADRs) with a keep/drop/defer decision for each. Default is keep; dropping a feature needs explicit user sign-off. A silently dropped capability is a release-blocking regression. Plans for such work must carry the inventory as a section (see the template in `docs/plans/`).
+
 ## Tokens are precious
 
 Every single line in CLAUDE.md will make agents worse at unrelated tasks.  Every single word must have significant lasting benefit or it must not be added.  Do not repeat yourself, do not add lines even if you screw up, if it is unlikely a similar screw up will happen again.  Always give the most general fix, to increase the likelihood the guidence is future-directed.
@@ -51,7 +55,7 @@ Django-based job/project management system for jobbing shops and custom work bus
 - **`workflow`** - Central hub, Xero integration, auth middleware
 - **`job`** - Job lifecycle, Kanban status tracking (Quoting → In Progress → Completed → Archived), audit trails
 - **`accounts`** - Custom Staff model extending AbstractBaseUser, authentication
-- **`client`** - Customer management, bidirectional Xero contact sync
+- **`company`** - Customer management, bidirectional Xero contact sync
 - **`timesheet`** - Time tracking, billable/non-billable, wage rates
 - **`purchasing`** - POs, stock management, Xero integration, links to CostLine via ext_refs
 - **`accounting`** - KPIs, financial reporting, invoice generation
@@ -65,7 +69,11 @@ Django-based job/project management system for jobbing shops and custom work bus
 Job → CostSet (1:many) → CostLine (1:many)
 PurchaseOrder → PurchaseOrderLine → Stock → CostLine
 Staff → CostLine (time entries)
-Client → Job (1:many)
+Company → Job (1:many)
+Person → Job (1:many)
+Person → PhoneCallRecord (1:many)
+Company → CompanyPersonLink → Person
+Company/Person → ContactMethod (1:many, exactly one owner)
 ```
 
 **Key Design Patterns:**
@@ -83,7 +91,7 @@ Client → Job (1:many)
 TIME entries (kind='time'):
 - staff_id (str, UUID): Reference to Staff member
 - date (str, ISO): Date work performed (legacy - use accounting_date field instead)
-- is_billable (bool): Whether billable to client
+- is_billable (bool): Whether billable to company
 - wage_rate_multiplier/rate_multiplier (float): Rate multiplier (e.g., 1.5 for overtime)
 - note (str): Optional notes
 - created_from_timesheet (bool): True if from modern timesheet UI

apps/accounting/migrations/0001_baseline.py

@@ -12,18 +12,8 @@ class Migration(migrations.Migration):
 
     initial = True
 
-    replaces = [
-        ("accounting", "0001_initial"),
-        ("accounting", "0002_initial"),
-        ("accounting", "0003_alter_invoice_job"),
-        ("accounting", "0004_protect_critical_fks"),
-        ("accounting", "0005_quote_number"),
-        ("accounting", "0006_alter_bill_table_alter_billlineitem_table_and_more"),
-        ("accounting", "0007_partial_invoice_billing_metadata"),
-    ]
-
     dependencies = [
-        ("client", "0001_baseline"),
+        ("company", "0001_baseline"),
     ]
 
     operations = [
@@ -424,7 +414,7 @@ class Migration(migrations.Migration):
                 (
                     "client",
                     models.ForeignKey(
-                        on_delete=django.db.models.deletion.PROTECT, to="client.client"
+                        on_delete=django.db.models.deletion.PROTECT, to="company.client"
                     ),
                 ),
             ],

apps/accounting/migrations/0002_baseline.py

@@ -8,13 +8,9 @@ class Migration(migrations.Migration):
 
     initial = True
 
-    replaces = [
-        ("accounting", "0008_normalize_xero_raw_json_strings"),
-    ]
-
     dependencies = [
         ("accounting", "0001_baseline"),
-        ("client", "0001_baseline"),
+        ("company", "0001_baseline"),
         ("job", "0001_baseline"),
         ("workflow", "0001_baseline"),
     ]
@@ -43,7 +39,7 @@ class Migration(migrations.Migration):
             model_name="creditnote",
             name="client",
             field=models.ForeignKey(
-                on_delete=django.db.models.deletion.PROTECT, to="client.client"
+                on_delete=django.db.models.deletion.PROTECT, to="company.client"
             ),
         ),
         migrations.AddField(
@@ -69,7 +65,7 @@ class Migration(migrations.Migration):
             model_name="invoice",
             name="client",
             field=models.ForeignKey(
-                on_delete=django.db.models.deletion.PROTECT, to="client.client"
+                on_delete=django.db.models.deletion.PROTECT, to="company.client"
             ),
         ),
         migrations.AddField(
@@ -106,7 +102,7 @@ class Migration(migrations.Migration):
             model_name="quote",
             name="client",
             field=models.ForeignKey(
-                on_delete=django.db.models.deletion.PROTECT, to="client.client"
+                on_delete=django.db.models.deletion.PROTECT, to="company.client"
             ),
         ),
         migrations.AddField(

apps/accounting/migrations/0003_rename_client_company.py

@@ -0,0 +1,30 @@
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+    dependencies = [
+        ("accounting", "0002_baseline"),
+    ]
+
+    operations = [
+        migrations.RenameField(
+            model_name="invoice",
+            old_name="client",
+            new_name="company",
+        ),
+        migrations.RenameField(
+            model_name="bill",
+            old_name="client",
+            new_name="company",
+        ),
+        migrations.RenameField(
+            model_name="creditnote",
+            old_name="client",
+            new_name="company",
+        ),
+        migrations.RenameField(
+            model_name="quote",
+            old_name="client",
+            new_name="company",
+        ),
+    ]

apps/accounting/models/invoice.py

@@ -6,7 +6,7 @@
 from django.utils import timezone
 
 if TYPE_CHECKING:
-    from apps.client.models import Client
+    from apps.company.models import Company
 
 from apps.accounting.enums import InvoiceStatus
 
@@ -23,7 +23,7 @@ class BaseXeroInvoiceDocument(models.Model):
         max_length=255, null=True, blank=True
     )  # For reference only - we are not fully multi-tenant yet
     number = models.CharField(max_length=255)
-    client = models.ForeignKey("client.Client", on_delete=models.PROTECT)
+    company = models.ForeignKey("company.Company", on_delete=models.PROTECT)
     date = models.DateField()
     due_date = models.DateField(null=True, blank=True)
     status = models.CharField(
@@ -43,7 +43,7 @@ class Meta:
         abstract = True
 
     def __str__(self) -> str:
-        return f"{self.number} - {self.client.name}"
+        return f"{self.number} - {self.company.name}"
 
     @property
     def total_amount(self) -> Decimal:
@@ -125,13 +125,13 @@ class Meta:
         ordering = ["-date", "number"]
 
     @property
-    def supplier(self) -> "Client":
-        """Return the client as 'supplier' for bills."""
-        return self.client
+    def supplier(self) -> "Company":
+        """Return the company as 'supplier' for bills."""
+        return self.company
 
     @supplier.setter
-    def supplier(self, value: "Client") -> None:
-        self.client = value
+    def supplier(self, value: "Company") -> None:
+        self.company = value
 
 
 class CreditNote(BaseXeroInvoiceDocument):

apps/accounting/models/quote.py

@@ -15,7 +15,7 @@ class Quote(models.Model):
     job = models.OneToOneField(
         "job.Job", on_delete=models.PROTECT, related_name="quote", null=True, blank=True
     )
-    client = models.ForeignKey("client.Client", on_delete=models.PROTECT)
+    company = models.ForeignKey("company.Company", on_delete=models.PROTECT)
     date = models.DateField()
     status = models.CharField(
         max_length=50, choices=QuoteStatus.choices, default=QuoteStatus.DRAFT

apps/accounting/serializers/core.py

@@ -21,7 +21,7 @@ class KPIJobBreakdownSerializer(serializers.Serializer[Any]):
         serializers.CharField()
     )  # Changed to CharField to match frontend schema
     job_name = serializers.CharField()  # Changed from job_display_name
-    client_name = serializers.CharField()  # Added client_name field
+    company_name = serializers.CharField()  # Added company_name field
     billable_hours = serializers.FloatField()  # Added billable_hours field
     revenue = serializers.FloatField()
     cost = serializers.FloatField()
@@ -160,7 +160,7 @@ class JobAgingJobDataSerializer(serializers.Serializer[Any]):
     id = serializers.CharField()
     job_number = serializers.IntegerField()
     name = serializers.CharField()
-    client_name = serializers.CharField()
+    company_name = serializers.CharField()
     status = serializers.CharField()
     status_display = serializers.CharField()
     financial_data = JobAgingFinancialDataSerializer()
@@ -208,7 +208,7 @@ class StaffPerformanceJobBreakdownSerializer(serializers.Serializer[Any]):
     job_id = serializers.CharField()
     job_number = serializers.IntegerField()
     job_name = serializers.CharField()
-    client_name = serializers.CharField()
+    company_name = serializers.CharField()
     billable_hours = serializers.FloatField()
     non_billable_hours = serializers.FloatField()
     total_hours = serializers.FloatField()

apps/accounting/serializers/rdti_spend_serializers.py

@@ -36,7 +36,7 @@ class RDTISpendJobDetailSerializer(serializers.Serializer[Any]):
     job_id = serializers.CharField()
     job_number = serializers.IntegerField()
     job_name = serializers.CharField()
-    client_name = serializers.CharField()
+    company_name = serializers.CharField()
     rdti_type = serializers.CharField()
     hours = serializers.FloatField()
     cost = serializers.FloatField()

apps/accounting/serializers/sales_pipeline_serializers.py

@@ -101,7 +101,7 @@ class SalesPipelineSnapshotJobSerializer(serializers.Serializer[Any]):
     id = serializers.CharField()
     job_number = serializers.IntegerField()
     name = serializers.CharField()
-    client_name = serializers.CharField(allow_blank=True)
+    company_name = serializers.CharField(allow_blank=True)
     hours = serializers.FloatField()
     value = serializers.FloatField()
     days_in_stage = serializers.IntegerField()

apps/accounting/serializers/wip_serializers.py

@@ -22,7 +22,7 @@ class WIPJobSerializer(serializers.Serializer[Any]):
 
     job_number = serializers.IntegerField()
     name = serializers.CharField()
-    client = serializers.CharField()
+    company = serializers.CharField()
     status = serializers.CharField()
     time_cost = serializers.FloatField()
     time_rev = serializers.FloatField()