Skip to content

fix mypy caching - #521

Open
corrin wants to merge 2 commits into
productionfrom
main
Open

fix mypy caching#521
corrin wants to merge 2 commits into
productionfrom
main

Conversation

@corrin

@corrin corrin commented Aug 2, 2026

Copy link
Copy Markdown
Owner

📝 Description

Short explanation of what you’ve built and why.

🔗 Related Jira Work Item

Jira: KAN-123

Use the uppercase Jira key (KAN-123) in the PR title or body so GitHub for
Jira links the development event. Jira Automation owns the transition to Done
when the PR is merged.

🚀 Changes

  • Bullet-list of feature additions or fixes (e.g. extracted useChat composable, split ChatHistory and ChatInput components, added Pinia store).

✅ Checklist

Vue.js (Composition API)

  • Used Composition API (<script setup> & composables), no heavy logic in templates
  • UI logic extracted to reusable composables (useChat, etc.)
  • Components are focused & small (<200 LOC)
  • Communication via props and emit, no direct parent/child ref duplication
  • State management in Pinia; no ad-hoc reactive globals
  • Routes/components lazy-loaded where appropriate

Quality & Formatting

  • Passes Prettier (npx prettier --check .)
  • Passes ESLint with zero warnings (npx eslint . --ext .js,.ts,.vue)
  • Added JSDoc comments for all props and emitted events
  • New or updated unit/E2E tests included

Definition of Done

  • Browser JavaScript console checked for relevant warnings/errors
  • Django/server console checked for relevant warnings/errors
  • Build, type-check, schema, and OpenAPI warnings reviewed; no new unexplained warnings
  • Weak frontend typing such as avoidable any or loose passthrough types reviewed
  • Affected business workflow regression-tested
  • User-facing workflow still makes sense for the relevant business user

See docs/jira-usage.md#required-checks.

corrin and others added 2 commits August 2, 2026 20:31
Backend Type Check ran full-strict mypy cold on every push (~2m15s).
Mypy is incremental, so restoring .mypy_cache lets it re-check only the
modules whose dependencies changed — typical pushes drop to seconds.
The key embeds the commit SHA because actions/cache never overwrites an
existing key; restore-keys falls back to the newest snapshot for the
same poetry.lock + pyproject.toml.

The other candidate (caching pre-commit hook environments) turned out
to already exist inside pre-commit/action@v3, so it is not duplicated
here.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PnuHL7w3UisSk6KQ81q3Qf
ci: cache mypy incremental state in Backend Type Check
@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9d11a95f-3354-4a9e-8364-54c68be4d1e3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant