fix(intercom): fail closed on missing webhook secret - #753
Draft
MikeGatsby wants to merge 1 commit into
Draft
Conversation
verifyIntercomWebhookSignature computed an HMAC with an empty secret instead of rejecting the request outright, matching the fail-closed guard already used by every other webhook plugin in the repo (typeform, stripe, notion, spotify, etc). Closes corsairdev#711
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
verifyIntercomWebhookSignaturecomputed an HMAC signature against an emptysecret instead of rejecting the request outright when no secret was
configured. Every other webhook plugin in this repo (typeform, stripe,
notion, spotify, gitlab, mailchimp, and ~25 others) already fails closed on
a missing secret with the same
{ valid: false, error: 'Missing webhook secret' }shape — Intercom (and Vercel, tracked separately in #712) werethe two outliers.
Fixes #711
Checklist
pnpm typecheckand there are no TypeScript errors(scoped to
@corsair-dev/intercom)pnpm testand all tests pass (scoped to@corsair-dev/intercom; pre-existing unrelated failures inapi.test.tscome from live Intercom API calls needing realcredentials, confirmed present before this change via git-stash A/B)
pnpm lint/pnpm buildnot run (nolintscript existsat the package level; a full monorepo build was out of scope for a
2-file fix — happy to run it if a maintainer wants it before merge)
Additional Notes
No behavior change to the signature comparison path — only adds the
missing-secret guard before the HMAC is computed, matching the repo's
established pattern exactly.