fix(pi): guard empty base64 images, error tool_results, and sanitize tool IDs#17
Open
iceteaSA wants to merge 1 commit into
Open
fix(pi): guard empty base64 images, error tool_results, and sanitize tool IDs#17iceteaSA wants to merge 1 commit into
iceteaSA wants to merge 1 commit into
Conversation
…tool IDs - Add sanitizeToolId() to strip chars outside [a-zA-Z0-9_-] from tool-call IDs, preventing Anthropic 400 errors from cross-provider ID incompatibility - Guard empty base64 image data to prevent invalid payloads - Inject fallback content for is_error=true tool_results with empty content, which Anthropic rejects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three related bugs in the PI message converter that cause Anthropic API 400 errors:
Tool ID sanitization — Tool-call IDs from non-Anthropic providers may contain characters outside
^[a-zA-Z0-9_-]+$. AddedsanitizeToolId()that strips invalid chars, guards empty IDs with'tool_call_unknown', and truncates at 256 chars. Applied at all 3tool_use_idassignment sites.Empty base64 image guard — Image content blocks with empty/falsy
datafield are now filtered out instead of sending invalid base64 payloads to Anthropic.Empty error content guard — When
is_error=truebut the content array is empty, Anthropic rejects the request. Now injects{ type: 'text', text: 'Error' }as fallback content.Testing
All existing tests pass. These are edge cases triggered by cross-provider message conversion (e.g. OpenAI-format tool calls routed through PI).