perf: accept optional storage in getUsableFallbackAccounts to avoid redundant disk reads#19
Open
iceteaSA wants to merge 1 commit into
Open
perf: accept optional storage in getUsableFallbackAccounts to avoid redundant disk reads#19iceteaSA wants to merge 1 commit into
iceteaSA wants to merge 1 commit into
Conversation
…edundant disk reads In the hot request path, loadAccounts() (readFile + JSON.parse) can fire multiple times per request. Callers that already have storage loaded can now pass it to skip the redundant disk read. Non-breaking: parameter is optional, existing callers unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional
existingStorageparameter toFallbackAccountManager.getUsableFallbackAccounts(). Callers that already have storage loaded (e.g., the fetch handler which loads it at the start of every request) can pass it through to skip a redundantreadFile+JSON.parse.In the hot request path,
loadAccounts()currently fires up to 3 times per request:tryFallbackAccounts()getUsableFallbackAccounts()This change eliminates #3 when the caller provides storage.
API Change
Uses
!== undefinedcheck (not falsy) becausenullis a valid "no storage file" state.Testing
All existing tests pass. No behavior change — only avoids redundant disk I/O.