Skip to content

fix(relay): handle WS errors during optimistic response streaming #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iceteaSA wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −0
Open

fix(relay): handle WS errors during optimistic response streaming #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions packages/core/src/relay.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -808,6 +808,23 @@ class PersistentRelaySession {
return
}
if (message.type === 'error') {
// If an optimistic response is already streaming (responseStartedAt is
// set), the pending promise was already resolved — calling failPending
// would reject a settled promise and leave the stream hanging. Instead,
// inject an SSE error event and close cleanly.
if (pending.optimisticResponse && pending.responseStartedAt != null) {
relayLog(
`websocket relay error during optimistic response session=${shortAffinity(this.affinity)} request=${pending.payload.id} status=${message.status} message=${message.message || 'unknown'}`,
)
pending.streamController?.enqueue(
new TextEncoder().encode(
`event: error\ndata: ${JSON.stringify({ type: 'error', error: { type: 'relay_error', message: message.message || 'relay error' } })}\n\n`,
),
)
this.finishPending()
this.socket?.close()
return
}
if (
message.status === 409 &&
this.retryPendingBeforeResponse(
Expand Down