chore: remove 'any' types and update metadata#23
Merged
Zoltan Hricz (hriczzoli) merged 3 commits intomainfrom Mar 17, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR focuses on tightening TypeScript typing (removing any-based narrowing) across error formatting and postMessage handling, while also updating package metadata and adding targeted tests to lock in the new behavior.
Changes:
- Add tests for
formatErrorto validate object-based error formatting and status-code extraction. - Replace
anyusage with type guards / safer narrowing inerrorFormatterandPostMessageHandler. - Update public API typing for
setCredentials, and refactor iframe sandbox policy into a constant.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/error-formatter.test.ts | Adds coverage for formatError object/JSON-details behavior. |
| src/utils/errorFormatter.ts | Introduces isRecord narrowing and refactors object error handling to avoid any. |
| src/utils/PostMessageHandler.ts | Adds type guards for incoming postMessage data and types pending request handlers. |
| src/types/api.ts | Switches setCredentials argument type to SetCredentialsPayload. |
| src/CortiEmbedded.ts | Replaces as any sandbox binding with a reusable constant. |
| package.json | Updates sideEffects metadata (now includes src/corti-embedded.ts). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Member
Morten Barklund (barklund)
left a comment
There was a problem hiding this comment.
Looks solid
Morten Barklund (barklund)
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.