chore: move element registration to main entry point and enforce double quotes#24
Merged
Zoltan Hricz (hriczzoli) merged 2 commits intomainfrom Mar 19, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes string quoting to double quotes across the codebase, and shifts side-effect element registration and DOM typing augmentation toward the main entrypoint.
Changes:
- Enforced double quotes by updating Prettier config and applying formatting updates across TS sources.
- Ensured
corti-embeddedelement registration happens via entrypoint imports. - Relocated the
CortiEmbeddedElementDOM typing/global augmentation fromsrc/types/api.tsintosrc/index.ts.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/web-index.ts | Uses double quotes; keeps web entry importing element registration + exporting public types. |
| src/utils/errorFormatter.ts | Quote-only formatting changes. |
| src/utils/embedUrl.ts | Quote-only formatting changes. |
| src/utils/baseUrl.ts | Quote-only formatting changes (incl. error strings). |
| src/utils/PostMessageHandler.ts | Quote-only formatting changes (message event strings, errors). |
| src/types/protocol.ts | Quote-only formatting changes for string literal unions. |
| src/types/payloads.ts | Quote-only formatting changes (incl. quoted property names / indexed access). |
| src/types/api.ts | Quote-only formatting changes; removes DOM global augmentation previously defined here. |
| src/styles/theme.ts | Quote-only formatting changes inside Lit CSS templates. |
| src/styles/container-styles.ts | Quote-only formatting changes inside Lit CSS templates. |
| src/styles/base.ts | Quote-only formatting changes. |
| src/react/index.ts | Quote-only formatting changes. |
| src/react/CortiEmbeddedReact.ts | Quote-only formatting changes; still imports element registration as a side effect. |
| src/index.ts | Imports element registration; adds DOM global augmentation + CortiEmbeddedElement type; re-exports public API/types. |
| src/corti-embedded.ts | Quote-only formatting changes for custom element registration. |
| src/CortiEmbedded.ts | Quote-only formatting changes (strings, attributes, event names). |
| package.json | Updates Prettier config to enforce double quotes (singleQuote: false). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Morten Barklund (barklund)
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.