Skip to content

chore: move element registration to main entry point and enforce double quotes#24

Merged
Zoltan Hricz (hriczzoli) merged 2 commits intomainfrom
update-element-registration-and-formating-rules
Mar 19, 2026
Merged

chore: move element registration to main entry point and enforce double quotes#24
Zoltan Hricz (hriczzoli) merged 2 commits intomainfrom
update-element-registration-and-formating-rules

Conversation

@hriczzoli
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes string quoting to double quotes across the codebase, and shifts side-effect element registration and DOM typing augmentation toward the main entrypoint.

Changes:

  • Enforced double quotes by updating Prettier config and applying formatting updates across TS sources.
  • Ensured corti-embedded element registration happens via entrypoint imports.
  • Relocated the CortiEmbeddedElement DOM typing/global augmentation from src/types/api.ts into src/index.ts.

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/web-index.ts Uses double quotes; keeps web entry importing element registration + exporting public types.
src/utils/errorFormatter.ts Quote-only formatting changes.
src/utils/embedUrl.ts Quote-only formatting changes.
src/utils/baseUrl.ts Quote-only formatting changes (incl. error strings).
src/utils/PostMessageHandler.ts Quote-only formatting changes (message event strings, errors).
src/types/protocol.ts Quote-only formatting changes for string literal unions.
src/types/payloads.ts Quote-only formatting changes (incl. quoted property names / indexed access).
src/types/api.ts Quote-only formatting changes; removes DOM global augmentation previously defined here.
src/styles/theme.ts Quote-only formatting changes inside Lit CSS templates.
src/styles/container-styles.ts Quote-only formatting changes inside Lit CSS templates.
src/styles/base.ts Quote-only formatting changes.
src/react/index.ts Quote-only formatting changes.
src/react/CortiEmbeddedReact.ts Quote-only formatting changes; still imports element registration as a side effect.
src/index.ts Imports element registration; adds DOM global augmentation + CortiEmbeddedElement type; re-exports public API/types.
src/corti-embedded.ts Quote-only formatting changes for custom element registration.
src/CortiEmbedded.ts Quote-only formatting changes (strings, attributes, event names).
package.json Updates Prettier config to enforce double quotes (singleQuote: false).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread src/index.ts Outdated
Comment thread src/index.ts Outdated
Comment thread src/react/CortiEmbeddedReact.ts
@hriczzoli Zoltan Hricz (hriczzoli) merged commit bfa4066 into main Mar 19, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants