feature: support GSUB 6 and 4 (contextual ligs)#3
Merged
Conversation
Generate rules for when to replace the sequence with a ligature. This is based on my understanding of the Fira code approach where a marker glyph is used to prevent matching in forbidden sequences. Currently, the sequence may only trigger when surrounded by white space.
FontTools warns that the glyphs are not sorted correctly. Not sorting correctly produces a technically invalid font but the shapers I've used seem to not mind. There is probably a scenario where a glyph lookup would fail so let's fix this now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate rules for when to replace the sequence with a ligature. This
is based on my understanding of the Fira code approach where a marker
glyph is used to prevent matching in forbidden sequences. Currently,
the sequence may only trigger when surrounded by white space.