test(skill): align gen-cli-ref test with flat layout from PR #189#647
Merged
Conversation
PR #189 removed versioned CLI-reference dirs + manifest.json from gen-cli-ref.sh (only the latest refs live under _shared/cli/, matching SKILL.md links), but test-gen-cli-ref.sh kept asserting the old <out>/<version>/ + manifest layout — failing on every run since. Assert the flat contract instead, and pin the absence of the removed versioned dir / manifest so a silent re-introduction fails loudly.
coseto6125
enabled auto-merge (squash)
July 22, 2026 17:01
Contributor
ecp impact cache (0 symbols) — internal, used by
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
tests/skill/test-gen-cli-ref.shhas failed on every run since PR #189 (May 2026), which intentionally removed the versioned CLI-reference directories +manifest.jsonfromgen-cli-ref.sh("keeping only the latest references directly under_shared/cli/") but left the test asserting the old<out>/<version>/+ manifest layout.The flat layout is the current design everywhere — on-disk (
docs/skills/ecp-onboard/_shared/cli/*.md) and in every SKILL.md link — so the fix is to make the test assert the flat contract:.mdfiles directly under the output dir, withUsage:contentmanifest.json, so a silent re-introduction of the abandoned layout fails loudlyVerified: test passes; full
tests/skill/suite green.Surfaced while validating PR #646 (the failure predates that change — reproduced identically on unmodified
main).