fix: activation for last layer of UNet2D#16
Open
hardik01shah wants to merge 2 commits intocosmic-cortex:masterfrom
Open
fix: activation for last layer of UNet2D#16hardik01shah wants to merge 2 commits intocosmic-cortex:masterfrom
hardik01shah wants to merge 2 commits intocosmic-cortex:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Softmax was being applied by default to the output of the Last2D block, and the
softmaxargument in the forward method was unused.Fixed it to use the argument to append a softmax layer only when the argument is True.
Last2D expects wrong input channels, only works when conv depths are multiplied by 2 at each depth. Fixed it to work when this condition does not hold.