Skip to content

fix: Update max privval size#36

Merged
Eric-Warehime merged 1 commit into
mainfrom
eric/audit1
Jul 21, 2026
Merged

fix: Update max privval size#36
Eric-Warehime merged 1 commit into
mainfrom
eric/audit1

Conversation

@Eric-Warehime

Copy link
Copy Markdown
Collaborator

Updates the max privval message size to mirror changes made upstream. This fixes the possibility of a large vote-extension enable precommit with mldsa validator exceeding the older default.

@Eric-Warehime
Eric-Warehime requested a review from a team as a code owner July 21, 2026 02:56
@greptile-apps

greptile-apps Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR raises the remote-signer message limit to support larger vote-extension precommits. The main change is:

  • Derive the framing cap from the maximum vote-extension and signature sizes instead of using a fixed 10 KiB limit.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
internal/manager/manager.go Replaces the fixed remote-signer framing limit with a size derived from supported vote extensions and signatures.

Reviews (1): Last reviewed commit: "Update max privval size" | Re-trigger Greptile

@Eric-Warehime
Eric-Warehime added this pull request to the merge queue Jul 21, 2026
Merged via the queue into main with commit 599e7fb Jul 21, 2026
8 checks passed
@Eric-Warehime
Eric-Warehime deleted the eric/audit1 branch July 21, 2026 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants