Remove VBucket-specific HashSet from BaseOperationImpl#29
Open
amcrn wants to merge 1 commit intocouchbase:masterfrom
Open
Remove VBucket-specific HashSet from BaseOperationImpl#29amcrn wants to merge 1 commit intocouchbase:masterfrom
amcrn wants to merge 1 commit intocouchbase:masterfrom
Conversation
The notMyVbucketNodes HashSet in BaseOperationImpl is only used for Couchbase operations. Given that spymemcached is a memcached client first and foremost, move notMyVbucketNodes to operation implementations that actually need it to relieve memory pressure for high throughput memcached-only applications.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The notMyVbucketNodes HashSet in BaseOperationImpl is only used for
Couchbase operations. Given that spymemcached is a memcached client
first and foremost, move notMyVbucketNodes to operation
implementations that actually need it to relieve memory pressure for
high throughput memcached-only applications.