Update 0057-sdk3-analytics.md#150
Open
programmatix wants to merge 4 commits into
Open
Conversation
mikereiche
previously approved these changes
Jun 19, 2025
avsej
previously approved these changes
Jun 20, 2025
chvck
previously approved these changes
Jun 23, 2025
chvck
reviewed
Jun 24, 2025
chvck
approved these changes
Oct 9, 2025
DemetrisChr
reviewed
Oct 29, 2025
Comment on lines
+197
to
+199
| [MB-67103](https://jira.issues.couchbase.com/browse/MB-67103) adds to the cluster and bucket configs a `prodName` string field identifying the cluster type. | ||
|
|
||
| Before performing each analytics operation, check the cluster config, and iff the prodName field is present, check if it starts with "Couchbase Server". If it doesn't, fast-fail the request with a generic `CouchbaseException`. A suitable error message could be: |
Contributor
There was a problem hiding this comment.
We ended up doing something slightly different to this. We are checking that the "prod" (not "prodName") field does not have the value "analytics". See https://jira.issues.couchbase.com/browse/CBD-6390
Contributor
There was a problem hiding this comment.
@programmatix I've pushed an update to this to reflect the change to using prod instead of prodName.
Contributor
Author
There was a problem hiding this comment.
Thank you - this slipped my notice.
chvck
approved these changes
Oct 29, 2025
chvck
reviewed
Oct 29, 2025
| | Language | Team Member | Signoff Date | Revision | | ||
| |------------|---------------------|-----------------|----------| | ||
| | Node.js | Jared Casey | May 1, 2025 | #3 | | ||
| | Go | Charles Dixon | April 22, 2020 | #1 | |
Contributor
There was a problem hiding this comment.
Suggested change
| | Go | Charles Dixon | October 29, 2025 | #4 | |
chvck
previously approved these changes
Oct 29, 2025
DemetrisChr
approved these changes
Apr 28, 2026
DemetrisChr
requested review from
avsej,
chvck,
dnault,
jeffrymorris and
thejcfactor
and removed request for
mikereiche
April 28, 2026 09:23
avsej
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.