Skip to content

fix(atomic): accessibility fixes for insight and IPX modals #7110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
y-lakhdar wants to merge 1 commit into from
Closed

fix(atomic): accessibility fixes for insight and IPX modals #7110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...atomic/src/components/insight/atomic-insight-refine-modal/atomic-insight-refine-modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ export class AtomicInsightRefineModal

private renderHeader() {
return (
<div class="mb-3 flex w-full justify-between">
<div class="flex justify-between w-full mb-3">
{this.breadcrumbManagerState.hasBreadcrumbs && (
<Button
onClick={() => this.breadcrumbManager.deselectAll()}
Expand All @@ -124,7 +124,7 @@ export class AtomicInsightRefineModal
}

return (
<aside slot="body" class="adjust-for-scroll-bar flex w-full flex-col">
<aside slot="body" class="flex flex-col w-full" aria-label={this.bindings.i18n.t('refine-modal-content')}>
{this.renderHeader()}
<slot name="facets"></slot>
</aside>
Expand Down
9 changes: 5 additions & 4 deletions ...ight/user-actions/atomic-insight-user-actions-modal/atomic-insight-user-actions-modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ export class AtomicInsightUserActionsModal
const renderHeader = () => {
return (
<div slot="header" class="contents">
<div part="title" class="truncate font-light">
<div part="title" class="font-light truncate">
{this.bindings.i18n.t('user-actions')}
</div>
<Button
Expand All @@ -99,7 +99,7 @@ export class AtomicInsightUserActionsModal
>
<atomic-icon
part="close-icon"
class="h-5 w-5"
class="w-5 h-5"
icon={CloseIcon}
></atomic-icon>
</Button>
Expand All @@ -112,7 +112,8 @@ export class AtomicInsightUserActionsModal
<aside
style={{height: '100%'}}
slot="body"
class="adjust-for-scroll-bar flex w-full flex-col px-2"
class="flex flex-col w-full px-2"
aria-label={this.bindings.i18n.t('user-actions-content')}
>
<atomic-insight-user-actions-timeline
userId={this.userId}
Expand All @@ -124,7 +125,7 @@ export class AtomicInsightUserActionsModal
);
};
return (
<Host>
<Host class="absolute">
{this.interfaceDimensions && (
<style>
{`atomic-modal::part(backdrop) {
Expand Down
4 changes: 2 additions & 2 deletions packages/atomic/src/components/ipx/atomic-ipx-refine-modal/atomic-ipx-refine-modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ export class AtomicIPXRefineModal implements InitializableComponent {

private renderHeader() {
return (
<div class="mb-3 flex w-full justify-between">
<div class="flex justify-between w-full mb-3">
{this.breadcrumbManagerState.hasBreadcrumbs && (
<Button
onClick={() => this.breadcrumbManager.deselectAll()}
Expand All @@ -100,7 +100,7 @@ export class AtomicIPXRefineModal implements InitializableComponent {
}

return (
<aside slot="body" class="adjust-for-scroll-bar flex w-full flex-col">
<aside slot="body" class="flex flex-col w-full" aria-label={this.bindings.i18n.t('refine-modal-content')}>
{this.renderHeader()}
<slot name="facets"></slot>
</aside>
Expand Down