feat(atomic) creation of agent generation steps component#7165
feat(atomic) creation of agent generation steps component#7165SimonMilord wants to merge 19 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a new Atomic (Lit) functional renderer intended to display agent generation steps (search/think/generate) while a generated answer is streaming, along with supporting localization strings, styling for a rolodex-like transition, and unit tests.
Changes:
- Added new i18n keys for agent “search” and “think” generation steps.
- Added generated-answer CSS keyframes/selectors for a rolodex animation.
- Added
renderAgentGenerationStepsfunctional component plus helper functions and unit tests.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| packages/atomic/src/locales.json | Adds new localized strings for agent generation step labels. |
| packages/atomic/src/components/common/generated-answer/styles/generated-answer.tw.css.ts | Adds keyframes and styling hooks for the generation-steps rolodex animation. |
| packages/atomic/src/components/common/generated-answer/render-agent-generation-steps.ts | Introduces a new functional renderer + step-selection helpers for agent generation steps. |
| packages/atomic/src/components/common/generated-answer/render-agent-generation-steps.spec.ts | Adds unit tests covering rendering and step-selection behavior. |
packages/atomic/src/components/common/generated-answer/render-agent-generation-steps.ts
Outdated
Show resolved
Hide resolved
packages/atomic/src/components/common/generated-answer/render-agent-generation-steps.ts
Show resolved
Hide resolved
packages/atomic/src/components/common/generated-answer/styles/generated-answer.tw.css.ts
Outdated
Show resolved
Hide resolved
packages/atomic/src/components/common/generated-answer/render-agent-generation-steps.spec.ts
Outdated
Show resolved
Hide resolved
packages/atomic/src/components/common/generated-answer/render-agent-generation-steps.spec.ts
Outdated
Show resolved
Hide resolved
packages/atomic/src/components/common/generated-answer/render-agent-generation-steps.ts
Outdated
Show resolved
Hide resolved
packages/atomic/src/components/common/generated-answer/render-agent-generation-steps.ts
Outdated
Show resolved
Hide resolved
mmitiche
left a comment
There was a problem hiding this comment.
The current implementation goes beyond the initial scope by introducing unnecessary complexity and implicit requirements.
At this stage, we should focus on a minimal, well-defined component that fulfills its core responsibility and enables fast iteration.
Especially With tight deadlines, simplicity is the key. Additional behaviour can be evaluated and introduced later if there’s a clear need.
packages/atomic/src/components/common/generated-answer/render-agent-generation-steps.ts
Outdated
Show resolved
Hide resolved
packages/atomic/src/components/common/generated-answer/render-agent-generation-steps.ts
Outdated
Show resolved
Hide resolved
packages/atomic/src/components/common/generated-answer/render-agent-generation-steps.ts
Outdated
Show resolved
Hide resolved
packages/atomic/src/components/common/generated-answer/render-agent-generation-steps.ts
Outdated
Show resolved
Hide resolved
packages/atomic/src/components/common/generated-answer/render-agent-generation-steps.ts
Outdated
Show resolved
Hide resolved
packages/atomic/src/components/common/generated-answer/render-agent-generation-steps.ts
Outdated
Show resolved
Hide resolved
|
Additionally, this PR should also integrate the new functional component to |
erocheleau
left a comment
There was a problem hiding this comment.
Some more thoughts must be given to where the logic resides. In my opinion it's not in the functional component.
SFINT-6647
IN THIS PR:
DEMO
Screen.Recording.2026-03-03.at.10.51.56.AM.mov