Skip to content

feat(atomic) creation of agent generation steps component#7165

Open
SimonMilord wants to merge 19 commits intomainfrom
SFINT-6647
Open

feat(atomic) creation of agent generation steps component#7165
SimonMilord wants to merge 19 commits intomainfrom
SFINT-6647

Conversation

@SimonMilord
Copy link
Contributor

@SimonMilord SimonMilord commented Feb 24, 2026

SFINT-6647

IN THIS PR:

  • Creation of the render-agent-generation-steps functional component component
  • Added rolodex-like animation
  • Added unit tests
  • Added 2 new labels in the locales.json for the search and thinking steps

DEMO

Screen.Recording.2026-03-03.at.10.51.56.AM.mov

Copy link
Contributor

@acarpentier01 acarpentier01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a new Atomic (Lit) functional renderer intended to display agent generation steps (search/think/generate) while a generated answer is streaming, along with supporting localization strings, styling for a rolodex-like transition, and unit tests.

Changes:

  • Added new i18n keys for agent “search” and “think” generation steps.
  • Added generated-answer CSS keyframes/selectors for a rolodex animation.
  • Added renderAgentGenerationSteps functional component plus helper functions and unit tests.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.

File Description
packages/atomic/src/locales.json Adds new localized strings for agent generation step labels.
packages/atomic/src/components/common/generated-answer/styles/generated-answer.tw.css.ts Adds keyframes and styling hooks for the generation-steps rolodex animation.
packages/atomic/src/components/common/generated-answer/render-agent-generation-steps.ts Introduces a new functional renderer + step-selection helpers for agent generation steps.
packages/atomic/src/components/common/generated-answer/render-agent-generation-steps.spec.ts Adds unit tests covering rendering and step-selection behavior.

Copy link
Contributor

@mmitiche mmitiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current implementation goes beyond the initial scope by introducing unnecessary complexity and implicit requirements.

At this stage, we should focus on a minimal, well-defined component that fulfills its core responsibility and enables fast iteration.
Especially With tight deadlines, simplicity is the key. Additional behaviour can be evaluated and introduced later if there’s a clear need.

@mmitiche
Copy link
Contributor

Additionally, this PR should also integrate the new functional component to atomic-answer-content.

Copy link
Collaborator

@erocheleau erocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more thoughts must be given to where the logic resides. In my opinion it's not in the functional component.

@github-actions
Copy link

github-actions bot commented Mar 2, 2026

🔗 Scratch Orgs ready to test this PR:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants