Skip to content

fix(atomic): reorder class fields in atomic-insight-result-action to follow convention#7176

Merged
fbeaudoincoveo merged 2 commits intoalexprudhomme/insight-result-action-4hhfrom
copilot/sub-pr-7172-another-one
Feb 26, 2026
Merged

fix(atomic): reorder class fields in atomic-insight-result-action to follow convention#7176
fbeaudoincoveo merged 2 commits intoalexprudhomme/insight-result-action-4hhfrom
copilot/sub-pr-7172-another-one

Conversation

Copy link
Contributor

Copilot AI commented Feb 26, 2026

Addresses review feedback on #7172: static styles was declared after @property and @state fields instead of immediately after the class declaration.

Changes

  • Reordered class fields in AtomicInsightResultAction to follow the established convention:
    1. static styles
    2. @property() decorated fields
    3. @state() decorated fields
    4. Non-decorated private fields

✅ Checklist

  • 🧪 The component is unit tested
  • 🧪 The component includes E2E tests
  • 🗑️ Old Cypress tests exclusive to the component are removed
  • 📖 The component is documented in storybook with an .mdx file
  • ♿ The component complies with the Web Content Accessibility Guidelines.
  • 🌐 All strings intended for humans or assistive technology must be localized with i18n.
  • 📦 The Lit component is exported in the appropriate index.ts and lazy-index.ts files.
  • 🎨 CSS parts are documented still accessible.
  • 🦥 Slotted Content, public methods and properties are documented
  • 🔄 The component outputs the same Angular output as before with Stencil
  • 🏷️ The component declares the component type in the HTMLElementTagNameMap

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…n to follow convention

Co-authored-by: fbeaudoincoveo <23503066+fbeaudoincoveo@users.noreply.github.com>
Copilot AI changed the title [WIP] Work in progress on atomic insight result action migration fix(atomic): reorder class fields in atomic-insight-result-action to follow convention Feb 26, 2026
@fbeaudoincoveo fbeaudoincoveo marked this pull request as ready for review February 26, 2026 14:07
@fbeaudoincoveo fbeaudoincoveo merged commit 4a8ac2b into alexprudhomme/insight-result-action-4hh Feb 26, 2026
3 checks passed
@fbeaudoincoveo fbeaudoincoveo deleted the copilot/sub-pr-7172-another-one branch February 26, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants