Skip to content

feat(main): add e2e with kamaji case#324

Merged
Timofei Larkin (lllamnyp) merged 2 commits into
cozystack:v1from
androndo:feat/e2e-tests
Jun 5, 2026
Merged

feat(main): add e2e with kamaji case#324
Timofei Larkin (lllamnyp) merged 2 commits into
cozystack:v1from
androndo:feat/e2e-tests

Conversation

@androndo

Copy link
Copy Markdown
Collaborator

No description provided.

@coderabbitai

coderabbitai Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5286590c-c28a-4a51-988d-369d6a1211f8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Revert the master->main trigger edits to ci.yml and publish.yml. These are pre-existing workflows unrelated to adding the e2e suite; publish.yml in particular would arm a push to a Docker Hub repo the project no longer owns. The new e2e.yml is unaffected and still gates PRs.

Signed-off-by: Timofei Larkin <lllamnyp@gmail.com>

@lllamnyp Timofei Larkin (lllamnyp) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything raised earlier is resolved.

  • Rebased onto v1 cleanly (merge-base is v1's tip), so the stale fork point is gone.
  • Plugin TLS tests reconciled to the corrected --cert-file detection — helpers_test.go now covers server-TLS-only, mTLS, no-cert-file, and mount-not-found via findSecretNameForTLS, with no overlap or helper-name collision against the getTLSConfig tests already on v1. Compiles and passes together.
  • Seed IsVoter fix (Status().UpdateStatus().Patch(MergeFrom)) rebased cleanly and keeps its concurrent-writer regression test.
  • Workflow-trigger changes dropped. I pushed a commit on top (f8bbeec, maintainer edit) reverting the mastermain edits to ci.yml and publish.yml back to their v1 state — they're pre-existing workflows unrelated to adding e2e, and publish.yml in particular would have armed a push to a Docker Hub repo the project no longer owns. The new e2e.yml is untouched and still gates PRs.

Build, go vet, the full unit suite, and make manifests generate (no drift) all pass on the rebased tree.

The e2e suite itself is the strong part: it proves the full consumer story end to end — an operator-managed full-mTLS EtcdCluster backs a Kamaji DataStore, a TenantControlPlane comes up on it, and a ConfigMap written through the tenant API is then found as a key in our etcd. The harness dumps diagnostics from the EXIT trap before teardown, pins component versions with rationale, and is build-tag-gated so it stays out of unit runs.

LGTM.

@lllamnyp Timofei Larkin (lllamnyp) merged commit e43e219 into cozystack:v1 Jun 5, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants