Skip to content

fix: generate_key() error-path resource leaks on OpenSSL 3.x #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atoomic merged 1 commit into from
Apr 3, 2026
Merged

fix: generate_key() error-path resource leaks on OpenSSL 3.x #108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 13 additions & 15 deletions RSA.xs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,11 +521,12 @@ generate_key(proto, bitsSV, exponent = 65537)
unsigned long exponent;
PREINIT:
EVP_PKEY* rsa = NULL;
BIGNUM *e = NULL;
#if OPENSSL_VERSION_NUMBER >= 0x30000000L
EVP_PKEY_CTX *ctx;
EVP_PKEY_CTX *ctx = NULL;
int error = 0;
#endif
CODE:
BIGNUM *e;
e = BN_new();
BN_set_word(e, exponent);
#if OPENSSL_VERSION_NUMBER < 0x00908000L
Expand All @@ -545,21 +546,18 @@ generate_key(proto, bitsSV, exponent = 65537)
#endif
#if OPENSSL_VERSION_NUMBER >= 0x30000000L
ctx = EVP_PKEY_CTX_new_from_name(NULL, "RSA", NULL);

if (!ctx
|| EVP_PKEY_keygen_init(ctx) != 1
|| EVP_PKEY_CTX_set_rsa_keygen_bits(ctx, SvIV(bitsSV)) <= 0
|| EVP_PKEY_CTX_set1_rsa_keygen_pubexp(ctx, e) <= 0
|| EVP_PKEY_generate(ctx, &rsa) != 1
|| rsa == NULL)
{
BN_free(e);
EVP_PKEY_CTX_free(ctx);
croakSsl(__FILE__, __LINE__);
}

THROW(ctx);
THROW(EVP_PKEY_keygen_init(ctx) == 1);
THROW(EVP_PKEY_CTX_set_rsa_keygen_bits(ctx, SvIV(bitsSV)) > 0);
THROW(EVP_PKEY_CTX_set1_rsa_keygen_pubexp(ctx, e) > 0);
THROW(EVP_PKEY_generate(ctx, &rsa) == 1);
err:
BN_free(e);
e = NULL;
EVP_PKEY_CTX_free(ctx);
ctx = NULL;
if (error)
croakSsl(__FILE__, __LINE__);
#endif
CHECK_OPEN_SSL(rsa);
RETVAL = make_rsa_obj(proto, rsa);
Expand Down
Loading