Skip to content

fix: free BN_CTX and temp BIGNUMs on success path #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atoomic merged 2 commits into from
Mar 19, 2026
Merged

fix: free BN_CTX and temp BIGNUMs on success path #112

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3fa511
fix: free BN_CTX and temp BIGNUMs on success in _new_key_from_paramet…
Koan-Bot Mar 16, 2026
7a10583
rebase: apply review feedback on #112
Koan-Bot Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion RSA.xs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,7 +623,7 @@ _new_key_from_parameters(proto, n, e, d, p, q)
}
else if (!q)
{
q = BN_new();
THROW(q = BN_new());
THROW(BN_div(q, NULL, n, p, ctx));
}
#if OLD_CRUFTY_SSL_VERSION
Expand Down Expand Up @@ -684,8 +684,19 @@ _new_key_from_parameters(proto, n, e, d, p, q)
#else
THROW(RSA_set0_crt_params(rsa, dmp1, dmq1, iqmp));
#endif
#endif
#if OPENSSL_VERSION_NUMBER >= 0x30000000L
BN_clear_free(dmp1);
BN_clear_free(dmq1);
BN_clear_free(iqmp);
#endif
dmp1 = dmq1 = iqmp = NULL;
Copy link
Copy Markdown
Member

@timlegge timlegge Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Koan-Bot did we miss freeing dmp1, dmq1 and iqmp

Copy link
Copy Markdown
Member

@timlegge timlegge Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Koan-Bot shouldn't dmp1, dmq1 and iqmp be freed on any openssl version?

BN_CTX_free(ctx);
ctx = NULL;
BN_clear_free(p_minus_1);
p_minus_1 = NULL;
BN_clear_free(q_minus_1);
q_minus_1 = NULL;
#if OPENSSL_VERSION_NUMBER >= 0x30000000L
OSSL_PARAM_BLD_free(params_build);
params_build = NULL;
Expand Down
Loading