Skip to content

fix: get_public_key_string() error-path leaks on 3.x #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atoomic merged 2 commits into from
Mar 19, 2026
Merged

fix: get_public_key_string() error-path leaks on 3.x #114

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6137eb8
fix: prevent resource leaks in get_public_key_string() on OpenSSL 3.x
Koan-Bot Mar 16, 2026
de4e020
rebase: apply review feedback on #114
Koan-Bot Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions RSA.xs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,22 +477,28 @@ get_public_key_string(p_rsa)
rsaData* p_rsa;
PREINIT:
BIO* stringBIO;
#if OPENSSL_VERSION_NUMBER >= 0x30000000L
OSSL_ENCODER_CTX *ctx = NULL;
int error = 0;
#endif
CODE:
CHECK_OPEN_SSL(stringBIO = BIO_new(BIO_s_mem()));
#if OPENSSL_VERSION_NUMBER >= 0x30000000L
OSSL_ENCODER_CTX *ctx = NULL;

ctx = OSSL_ENCODER_CTX_new_for_pkey(p_rsa->rsa, OSSL_KEYMGMT_SELECT_PUBLIC_KEY,
"PEM", "PKCS1", NULL);
if (!ctx || !OSSL_ENCODER_CTX_get_num_encoders(ctx)
|| OSSL_ENCODER_to_bio(ctx, stringBIO) != 1)
{
OSSL_ENCODER_CTX_free(ctx);
BIO_free(stringBIO);
croakSsl(__FILE__, __LINE__);
}
THROW(ctx != NULL && OSSL_ENCODER_CTX_get_num_encoders(ctx));

THROW(OSSL_ENCODER_to_bio(ctx, stringBIO) == 1);

OSSL_ENCODER_CTX_free(ctx);
ctx = NULL;

goto pubkey_done;
err:
if (ctx) { OSSL_ENCODER_CTX_free(ctx); ctx = NULL; }
BIO_free(stringBIO);
CHECK_OPEN_SSL(0);
pubkey_done:
#else
PEM_write_bio_RSAPublicKey(stringBIO, p_rsa->rsa);
#endif
Expand Down
Loading