ci: use prove directly instead of make test fallback#125
Merged
timlegge merged 1 commit intoMar 20, 2026
Merged
Conversation
Replace `make && ( make test || prove -wbvm t/*.t )` with `make && prove -wbvm t/*.t` in all CI jobs. The old pattern ran tests twice on failure: first via `make test` (TAP summary only), then via `prove -wbvm` (verbose). This doubled CI time on failures and flooded logs with redundant output. Since `prove -wbvm` already provides better diagnostics than `make test`, just use it directly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
timlegge
approved these changes
Mar 19, 2026
Member
timlegge
left a comment
timlegge
left a comment
There was a problem hiding this comment.
Looks fine. Logs are longer an event of success but I really really look at the logs to see failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace
make && ( make test || prove -wbvm t/*.t )withmake && prove -wbvm t/*.tin all CI jobs.Why
The old pattern ran tests twice on failure: first
make test(minimal TAP output), thenprove -wbvm(verbose). This wasted CI minutes and flooded logs with redundant output — making actual failures harder to find.How
Removed the
( make test || ... )wrapper in 4 jobs (ubuntu, perl, windows, macos). Theopenssl-matrixjob already used the clean form.Testing
prove -wbvm t/*.tis strictly more informative thanmake test— no behavior change on success🤖 Generated with Claude Code
Quality Report
Changes: 1 file changed, 4 insertions(+), 4 deletions(-)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline