Skip to content

fix: canonical two-pass buffer allocation in rsa_crypt() #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timlegge merged 1 commit into from
Mar 21, 2026
Merged

fix: canonical two-pass buffer allocation in rsa_crypt() #131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions RSA.xs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ SV* rsa_crypt(rsaData* p_rsa, SV* p_from,
SIZE_T_INT to_length;
int size;
unsigned char* from;
UNSIGNED_CHAR *to;
UNSIGNED_CHAR *to = NULL;
SV* sv;

from = (unsigned char*) SvPV(p_from, from_length);
Expand All @@ -361,11 +361,9 @@ SV* rsa_crypt(rsaData* p_rsa, SV* p_from,
"Use use_pkcs1_oaep_padding() for encryption, or use_pkcs1_padding() with sign()/verify().");
}

CHECK_NEW(to, size, UNSIGNED_CHAR);
#if OPENSSL_VERSION_NUMBER >= 0x30000000L

if(p_rsa->padding == RSA_PKCS1_PSS_PADDING) {
Safefree(to);
croak("PKCS#1 v2.1 RSA-PSS cannot be used for encryption operations call \"use_pkcs1_oaep_padding\" instead.");
}

Expand All @@ -387,6 +385,8 @@ SV* rsa_crypt(rsaData* p_rsa, SV* p_from,
}
THROW(EVP_PKEY_CTX_set_rsa_padding(ctx, crypt_pad) > 0);
THROW(p_crypt(ctx, NULL, &to_length, from, from_length) == 1);
Newx(to, to_length, UNSIGNED_CHAR);
THROW(to);
THROW(p_crypt(ctx, to, &to_length, from, from_length) == 1);

EVP_PKEY_CTX_free(ctx);
Expand All @@ -398,6 +398,7 @@ SV* rsa_crypt(rsaData* p_rsa, SV* p_from,
CHECK_OPEN_SSL(0);
crypt_done:
#else
CHECK_NEW(to, size, UNSIGNED_CHAR);
to_length = p_crypt(
from_length, from, (unsigned char*) to, p_rsa->rsa, p_rsa->padding);
#endif
Expand Down
Loading