Skip to content

fix: remove static buffer in get_message_digest() for thread safety #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timlegge merged 1 commit into from
Mar 22, 2026
Merged

fix: remove static buffer in get_message_digest() for thread safety #136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions RSA.xs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,14 +214,11 @@ EVP_MD *get_md_bynid(int hash_method)
}
}
#endif
unsigned char* get_message_digest(SV* text_SV, int hash_method)
unsigned char* get_message_digest(SV* text_SV, int hash_method, unsigned char* md)
{
STRLEN text_length;
unsigned char* text;
unsigned char *md;
static unsigned char m[EVP_MAX_MD_SIZE];
text = (unsigned char*) SvPV(text_SV, text_length);
md = m;

switch(hash_method)
{
Expand Down Expand Up @@ -1115,7 +1112,8 @@ sign(p_rsa, text_SV)
croak("Public keys cannot sign messages");
}

CHECK_OPEN_SSL(digest = get_message_digest(text_SV, p_rsa->hashMode));
unsigned char digest_buf[EVP_MAX_MD_SIZE];
CHECK_OPEN_SSL(digest = get_message_digest(text_SV, p_rsa->hashMode, digest_buf));
#if OPENSSL_VERSION_NUMBER >= 0x30000000L
ctx = EVP_PKEY_CTX_new(p_rsa->rsa, NULL /* no engine */);
THROW(ctx);
Expand Down Expand Up @@ -1193,7 +1191,8 @@ PPCODE:
croak("Signature longer than key");
}

CHECK_OPEN_SSL(digest = get_message_digest(text_SV, p_rsa->hashMode));
unsigned char digest_buf[EVP_MAX_MD_SIZE];
CHECK_OPEN_SSL(digest = get_message_digest(text_SV, p_rsa->hashMode, digest_buf));
#if OPENSSL_VERSION_NUMBER >= 0x30000000L
ctx = EVP_PKEY_CTX_new(p_rsa->rsa, NULL /* no engine */);
THROW(ctx);
Expand Down
Loading