Skip to content

fix: resource leaks in _new_key_from_parameters() init on 3.x #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atoomic merged 1 commit into from
Mar 24, 2026
+7 −6
Merged

fix: resource leaks in _new_key_from_parameters() init on 3.x #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions MANIFEST
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ t/format.t
t/key_lifecycle.t
t/padding.t
t/private_crypt.t
t/pss_auto_promote.t
t/rsa.t
t/sig_die.t
t/sign_verify.t
Expand Down
12 changes: 6 additions & 6 deletions RSA.xs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,7 +614,7 @@ _new_key_from_parameters(proto, n, e, d, p, q)
BIGNUM* dmp1 = NULL;
BIGNUM* dmq1 = NULL;
BIGNUM* iqmp = NULL;
int error;
int error = 0;
#if OPENSSL_VERSION_NUMBER >= 0x30000000L
OSSL_PARAM *params = NULL;
EVP_PKEY_CTX *pctx = NULL;
Expand All @@ -628,10 +628,10 @@ _new_key_from_parameters(proto, n, e, d, p, q)
}
#if OPENSSL_VERSION_NUMBER >= 0x30000000L
pctx = EVP_PKEY_CTX_new_from_name(NULL, "RSA", NULL);
CHECK_OPEN_SSL(pctx != NULL);
CHECK_OPEN_SSL(EVP_PKEY_fromdata_init(pctx) > 0);
THROW(pctx != NULL);
THROW(EVP_PKEY_fromdata_init(pctx) > 0);
params_build = OSSL_PARAM_BLD_new();
CHECK_OPEN_SSL(params_build)
THROW(params_build);
#else
CHECK_OPEN_SSL(rsa = RSA_new());
#endif
Expand All @@ -640,8 +640,8 @@ _new_key_from_parameters(proto, n, e, d, p, q)
rsa->e = e;
#endif
#if OPENSSL_VERSION_NUMBER >= 0x30000000L
CHECK_OPEN_SSL(OSSL_PARAM_BLD_push_BN(params_build, OSSL_PKEY_PARAM_RSA_N, n));
CHECK_OPEN_SSL(OSSL_PARAM_BLD_push_BN(params_build, OSSL_PKEY_PARAM_RSA_E, e));
THROW(OSSL_PARAM_BLD_push_BN(params_build, OSSL_PKEY_PARAM_RSA_N, n));
THROW(OSSL_PARAM_BLD_push_BN(params_build, OSSL_PKEY_PARAM_RSA_E, e));
#endif
if (p || q)
{
Expand Down
Loading