Skip to content

fix: BIO resource leak in extractBioString() error paths #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timlegge merged 3 commits into from
Apr 3, 2026
+11 −3
Merged

fix: BIO resource leak in extractBioString() error paths #145

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
404931b
fix: BIO resource leak in extractBioString() error paths
toddr-bot Mar 27, 2026
4f2f0a1
rebase: apply review feedback on #145
toddr-bot Apr 3, 2026
67513ea
rebase: apply review feedback on #145
toddr-bot Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions RSA.xs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,16 +293,24 @@ SV* extractBioString(BIO* p_stringBio)
{
SV* sv;
char* datap;
long datasize = 0;
long datasize;
int error = 0;

CHECK_OPEN_SSL(BIO_flush(p_stringBio) == 1);
THROW(BIO_flush(p_stringBio) == 1);

datasize = BIO_get_mem_data(p_stringBio, &datap);
THROW(datasize > 0);

Copy link
Copy Markdown
Member

@timlegge timlegge Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strictly speaking this should be > 0 - 0 is returned if p_stringBio is null but 299 should fail in that case

sv = newSVpv(datap, datasize);

CHECK_OPEN_SSL(BIO_set_close(p_stringBio, BIO_CLOSE) == 1);
BIO_set_close(p_stringBio, BIO_CLOSE);
Copy link
Copy Markdown
Member

@timlegge timlegge Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We lost the success check here - should wrap probably it in a throw but the p_stringBio was successfully set and the BIO is freed next so likely okay

BIO_free(p_stringBio);
return sv;

err:
BIO_free(p_stringBio);
CHECK_OPEN_SSL(0);
return NULL; /* unreachable, CHECK_OPEN_SSL croaks */
}

EVP_PKEY* _load_rsa_key(SV* p_keyStringSv,
Expand Down
Loading