Skip to content

fix: eliminate duplicate NID→name table in get_message_digest() #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timlegge merged 1 commit into from
Apr 3, 2026
Merged

fix: eliminate duplicate NID→name table in get_message_digest() #157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 11 additions & 26 deletions RSA.xs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,33 +220,18 @@ unsigned char* get_message_digest(SV* text_SV, int hash_method, unsigned char* m
unsigned char* text;
text = (unsigned char*) SvPV(text_SV, text_length);

switch(hash_method)
{
#if OPENSSL_VERSION_NUMBER >= 0x30000000L
case NID_md5:
return EVP_Q_digest(NULL, "MD5", NULL, text, text_length, md, NULL) ? md : NULL;
break;
case NID_sha1:
return EVP_Q_digest(NULL, "SHA1", NULL, text, text_length, md, NULL) ? md : NULL;
break;
#ifdef SHA512_DIGEST_LENGTH
case NID_sha224:
return EVP_Q_digest(NULL, "SHA224", NULL, text, text_length, md, NULL) ? md : NULL;
break;
case NID_sha256:
return EVP_Q_digest(NULL, "SHA256", NULL, text, text_length, md, NULL) ? md : NULL;
break;
case NID_sha384:
return EVP_Q_digest(NULL, "SHA384", NULL, text, text_length, md, NULL) ? md : NULL;
break;
case NID_sha512:
return EVP_Q_digest(NULL, "SHA512", NULL, text, text_length, md, NULL) ? md : NULL;
break;
#endif
case NID_ripemd160:
return EVP_Q_digest(NULL, "RIPEMD160", NULL, text, text_length, md, NULL) ? md : NULL;
break;
/* Delegate NID→name lookup to get_md_bynid() — single source of truth. */
{
EVP_MD *md_obj = get_md_bynid(hash_method); /* croak()s on unknown NID */
unsigned int result_len;
int ok = EVP_Digest(text, text_length, md, &result_len, md_obj, NULL);
EVP_MD_free(md_obj);
return ok ? md : NULL;
}
#else
switch(hash_method)
{
case NID_md5:
return MD5(text, text_length, md);
break;
Expand All @@ -270,7 +255,6 @@ unsigned char* get_message_digest(SV* text_SV, int hash_method, unsigned char* m
case NID_ripemd160:
return RIPEMD160(text, text_length, md);
break;
#endif
#ifdef WHIRLPOOL_DIGEST_LENGTH
case NID_whirlpool:
return WHIRLPOOL(text, text_length, md);
Expand All @@ -280,6 +264,7 @@ unsigned char* get_message_digest(SV* text_SV, int hash_method, unsigned char* m
croak("Unknown digest hash mode %u", hash_method);
break;
}
#endif
}

SV* cor_bn2sv(const BIGNUM* p_bn)
Expand Down
Loading