Skip to content

fix: drain error queue in _get_key_parameters() on 3.x #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timlegge merged 1 commit into from
Apr 5, 2026
Merged

fix: drain error queue in _get_key_parameters() on 3.x #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions MANIFEST
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ t/error.t
t/error_queue.t
t/fakelib/Crypt/OpenSSL/Bignum.pm
t/format.t
t/get_key_parameters.t
t/key_lifecycle.t
t/keygen.t
t/padding.t
Expand Down
4 changes: 3 additions & 1 deletion RSA.xs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1096,7 +1096,9 @@ PPCODE:
EVP_PKEY_get_bn_param(rsa, OSSL_PKEY_PARAM_RSA_EXPONENT1, &dmp1);
EVP_PKEY_get_bn_param(rsa, OSSL_PKEY_PARAM_RSA_EXPONENT2, &dmq1);
EVP_PKEY_get_bn_param(rsa, OSSL_PKEY_PARAM_RSA_COEFFICIENT1, &iqmp);
/* Drain any errors pushed by expected failures on public keys. */
/* Failed calls (e.g. private params on a public key) push errors
onto the OpenSSL error queue. Drain them so they don't leak
into the next croakSsl() call from an unrelated operation. */
ERR_clear_error();
#else
RSA_get0_key(rsa, &n, &e, &d);
Expand Down
Loading