fix: sign() double buffer allocation and error-path leaks (OpenSSL 3.x)#80
Merged
atoomic merged 1 commit intoMar 14, 2026
Merged
Conversation
Two issues in the OpenSSL 3.x signing path: 1. The signature buffer was allocated twice: first via CHECK_NEW for EVP_PKEY_get_size bytes, then overwritten by Newx after querying the actual size via EVP_PKEY_sign(NULL), leaking the first buffer. 2. If any OpenSSL call failed mid-setup, CHECK_OPEN_SSL would croak immediately, leaking the EVP_PKEY_CTX and EVP_MD objects. Fix: use THROW/goto err pattern for proper cleanup, and allocate the signature buffer only once after querying the needed size. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two issues in the OpenSSL 3.x signing path:
Double buffer allocation: The signature buffer was allocated twice — first via
CHECK_NEW(forEVP_PKEY_get_sizebytes), then overwritten byNewxafter querying the actual needed size. The first allocation leaked every time.Error-path resource leaks: If any OpenSSL call failed mid-setup,
CHECK_OPEN_SSLwouldcroak()immediately, leaking theEVP_PKEY_CTXandEVP_MDobjects.Fix
EVP_PKEY_sign(ctx, NULL, ...)CHECK_OPEN_SSLwithTHROW()/goto errpattern for proper cleanupEVP_PKEY_CTXandEVP_MDvariable declarations toPREINIT:for function-wide scopeTest plan
🤖 Generated with Claude Code