test: improve assertions in format.t and padding.t#86
Merged
atoomic merged 2 commits intoMar 13, 2026
Conversation
Replace legacy `use Test` with `use Test::More` and convert all 19 bare ok($a eq $b) comparisons to is($a, $b, "description") for better diagnostics on failure — showing expected vs got values instead of just "not ok". Co-Authored-By: Kōan <noreply@anthropic.com>
Convert bare ok($a eq $b) and ok($a == $b) to is() with descriptive test names for better failure diagnostics. Co-Authored-By: Kōan <noreply@anthropic.com>
atoomic
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Migrate
format.tfrom legacyTesttoTest::Moreand replace bareok()comparisons withis()in bothformat.tandpadding.t.Why
Follows up on PR #85 which did the same for
rsa.t. Theformat.tfile was the last test using the legacyTestmodule. Bareok($a eq $b)gives no diagnostic on failure —is()shows expected vs got values, making failures immediately actionable.How
use Test→use Test::More, all 19 assertions converted tois()with descriptive namesok()comparisons converted tois()with descriptionsTesting
Full test suite passes (281 tests, 10 files).
🤖 Generated with Claude Code
Quality Report
Changes: 2 files changed, 25 insertions(+), 25 deletions(-)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline