test: add descriptive names to bare ok() in rsa.t#93
Merged
atoomic merged 1 commit intoMar 14, 2026
Conversation
Every ok() call now has a test name, making failures easier to diagnose and test output more readable. No behavioral changes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add descriptive test names to all 9 bare
ok()calls int/rsa.t.Why
Bare
ok()without names produces anonymous output likeok 12on failure,making it hard to identify what broke without cross-referencing line numbers.
How
Each
ok(expr)→ok(expr, "descriptive name"). No logic changes.Testing
make test— 281 tests pass.🤖 Generated with Claude Code