Skip to content

test: fix always-true ok(defined $@) assertion in padding.t #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atoomic merged 1 commit into from
Mar 16, 2026
Merged

test: fix always-true ok(defined $@) assertion in padding.t #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions t/padding.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ Crypt::OpenSSL::RSA->import_random_seed();

my $rsa = Crypt::OpenSSL::RSA->generate_key(2048);
is( $rsa->size() * 8, 2048, "2048-bit key has correct size" );
ok( $rsa->check_key() );
ok( $rsa->check_key(), "2048-bit key passes check_key()" );

my $private_key_string = $rsa->get_private_key_string();
my $public_key_string = $rsa->get_public_key_string();
Expand Down Expand Up @@ -142,11 +142,17 @@ foreach my $padding (keys %padding_methods) {

# Invalid signing methods
if ((!$sign) && $pad) {
SKIP: {
# OAEP only affects encryption; signing uses its own padding
# and does not croak when OAEP is set
skip "Signing with $padding padding does not croak", 1
if $encrypt;
eval {
$rsa->$method;
$rsa->sign($plaintext);
};
ok(defined $@, "Padding $padding is invalid for signing");
ok($@, "Padding $padding is invalid for signing with $hash");
}
}

# Valid encryption methods with padding
Expand Down
Loading