Skip to content

fix: strptime day-name removal fails for non-ASCII byte encodings #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atoomic merged 5 commits into from
Apr 29, 2026
Merged

fix: strptime day-name removal fails for non-ASCII byte encodings #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
66163fa
fix: strptime day-name removal fails for non-ASCII byte encodings
Koan-Bot Apr 6, 2026
acfdd2a
fix: day-name regex uses alternation to avoid mandatory trailing space
Koan-Bot Apr 27, 2026
4d82a0f
fix: resolve CI failures on #106 (attempt 1)
Koan-Bot Apr 27, 2026
0da000d
fix: revert unnecessary CI workflow change per review feedback
Koan-Bot Apr 29, 2026
cee2ca4
fix: resolve CI failures on #106 (attempt 1)
Koan-Bot Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/Date/Parse.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ sub {
# ignore day names
$dtstr =~ s#([\d\w\s])[\.\,]\s#$1 #sog;
$dtstr =~ s/(?<!\d),|,(?!\d)/ /g;
$dtstr =~ s#($daypat)\s*(den\s)?\b# #o;
$dtstr =~ s#($daypat)(?![a-zA-Z])(\s+(den\s)?|\s*)# #o;
# Time: 12:00 or 12:00:00 with optional am/pm

return unless $dtstr =~ /\S/;
Expand Down
12 changes: 7 additions & 5 deletions t/lang.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,13 @@ use Date::Language;
my $time = time;

my @lang = qw(
English German Italian Bulgarian
French Spanish Swedish Norwegian
Danish Dutch Romanian Czech
Hungarian Finnish Austrian Brazilian
Portuguese Turkish
Afar Amharic Arabic Austrian Brazilian Bulgarian
Chinese Chinese_GB Czech Danish Dutch English
Finnish French Gedeo German Greek Hungarian
Icelandic Italian Norwegian Occitan Oromo
Portuguese Romanian Russian Russian_cp1251
Russian_koi8r Sidama Somali Spanish Swedish
Tigrinya TigrinyaEritrean TigrinyaEthiopian Turkish
);

for my $lang (@lang) {
Expand Down
Loading