Skip to content

fix: correct Arabic March translation and day suffixes #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Koan-Bot wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: correct Arabic March translation and day suffixes #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/Date/Language/Arabic.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@ use base 'Date::Language';
our (@DoW, @DoWs, @MoY, @MoYs, @AMPM, @Dsuf, %MoY, %DoW);

@DoW = qw(الأحد الاثنين الثلاثاء الأربعاء الخميس الجمعة السبت);
@MoY = qw(يناير فبراير مسيرة أبريل مايو يونيو يوليو أغسطس سبتمبر أكتوبر نوفمبر ديسمبر);
@MoY = qw(يناير فبراير مارس أبريل مايو يونيو يوليو أغسطس سبتمبر أكتوبر نوفمبر ديسمبر);
@DoWs = map { substr($_,0,3) } @DoW;
@MoYs = map { substr($_,0,3) } @MoY;
$MoYs[6] = 'يوليو';
@AMPM = qw(صباحا مساءا);

@Dsuf = ((qw(er e e e e e e e e e)) x 3, 'er'); #To be amended
@Dsuf = ('') x 31;

Date::Language::_build_lookups();

Expand Down
9 changes: 9 additions & 0 deletions t/lang-data.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,4 +116,13 @@ for my $lang (sort keys %expected) {
"Russian: Monday formats as Понедельник");
}

# Regression: Arabic March must be مارس (māris), not مسيرة (masira = procession)
{
my $ar = Date::Language->new('Arabic');
# Mon Mar 1 12:00:00 1999 UTC — mon=2 (March)
my $mar_time = 920289600;
is($ar->time2str('%B', $mar_time, 'GMT'), "\x{645}\x{627}\x{631}\x{633}",
"Arabic: March is \x{645}\x{627}\x{631}\x{633} (m\x{101}ris), not \x{645}\x{633}\x{64a}\x{631}\x{629} (masira)");
}

done_testing;
Loading