Skip to content

fix: strftime class method uses wrong package for language dispatch #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Koan-Bot wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: strftime class method uses wrong package for language dispatch #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/Date/Format/Generic.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ sub strftime

($pkg,$fmt,$time,$tzname) = @_;

my $me = ref($pkg) ? $pkg : bless [];
my $me = ref($pkg) ? $pkg : bless [], $pkg;

if(defined $tzname)
{
Expand Down
48 changes: 48 additions & 0 deletions t/strftime-lang.t
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
use strict;
use warnings;
use Test::More;
use Date::Language;

# Test that strftime produces language-specific output via both
# object method calls and class method calls.
#
# Bug: strftime() used 'bless []' without specifying the package,
# so class method calls like Date::Language::German->strftime(...)
# always produced English output instead of German.

# Use a fixed time: Wednesday 2025-01-15 10:30:00
# wday=3 (Wednesday), month=0 (January)
my @time = (0, 30, 10, 15, 0, 125, 3, 14, 0);

# --- Object method (the common path) ---

my $de = Date::Language->new('German');
my $fmt_obj = $de->strftime("%A %B", \@time);
like($fmt_obj, qr/Mittwoch/i, "strftime object method: German weekday name");
like($fmt_obj, qr/Januar/i, "strftime object method: German month name");

my $fr = Date::Language->new('French');
$fmt_obj = $fr->strftime("%A %B", \@time);
like($fmt_obj, qr/mercredi/i, "strftime object method: French weekday name");
like($fmt_obj, qr/janvier/i, "strftime object method: French month name");

# --- Class method (the buggy path before fix) ---

require Date::Language::German;
my $fmt_cls = Date::Language::German->strftime("%A %B", \@time);
like($fmt_cls, qr/Mittwoch/i, "strftime class method: German weekday name");
like($fmt_cls, qr/Januar/i, "strftime class method: German month name");

require Date::Language::French;
$fmt_cls = Date::Language::French->strftime("%A %B", \@time);
like($fmt_cls, qr/mercredi/i, "strftime class method: French weekday name");
like($fmt_cls, qr/janvier/i, "strftime class method: French month name");

# --- Verify time2str also works (already correct, but let's confirm) ---

my $epoch = 1736935800; # 2025-01-15 10:30:00 UTC
my $t2s = Date::Language::German->time2str("%A %B", $epoch, "UTC");
like($t2s, qr/Mittwoch/i, "time2str class method: German weekday name");
like($t2s, qr/Januar/i, "time2str class method: German month name");

done_testing;
Loading