test: add Expat.pm input validation and state guard tests#266
Merged
Conversation
Cover previously untested defensive code paths: - setHandlers rejects non-CODE references (string, hash, array, number) - setHandlers accepts undef/0 to clear handlers - Odd argument count and unknown handler type detection - "Parse already in progress" guard against concurrent parse - "Parser has already been used" guard against Expat reuse - Reference exceptions (blessed objects) preserved through parse - Reference exceptions preserved even with ErrorContext set - State-dependent methods return false outside active parse Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #266 +/- ##
=======================================
Coverage 75.73% 75.73%
=======================================
Files 1 1
Lines 1092 1092
Branches 342 342
=======================================
Hits 827 827
Misses 59 59
Partials 206 206
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add 22 tests covering previously untested defensive code paths in Expat.pm.
Why
Several core validation and state management paths had zero test coverage:
setHandlers()input validation (non-CODE ref rejection, odd argument count, unknown types)_State_checks preventing concurrent/reuse scenarios)How
New test file
t/expat_guards.texercises each path directly:setHandlersvalidation — rejects strings, hashrefs, arrayrefs, numbers, scalar refs; accepts undef/0; detects odd args and unknown typesTesting
Full test suite passes: 700 tests across 60 files.
🤖 Generated with Claude Code