Skip to content

Address CPANTS Kwalitee issues#267

Merged
toddr merged 1 commit into
mainfrom
koan.toddr.bot/fix-kwalitee-issues
Apr 23, 2026
Merged

Address CPANTS Kwalitee issues#267
toddr merged 1 commit into
mainfrom
koan.toddr.bot/fix-kwalitee-issues

Conversation

@toddr-bot
Copy link
Copy Markdown
Collaborator

@toddr-bot toddr-bot commented Apr 23, 2026

What

Address all 7 failing CPANTS Kwalitee metrics identified at
https://cpants.cpanauthors.org/release/TODDR/XML-Parser-2.57

Why

CPANTS Kwalitee scores affect distribution discoverability and signal
quality to downstream users. The core metric (has_license_in_source_file)
directly impacts the Kwalitee score.

How

Core fix: Added =head1 LICENSE section to Parser.pm with the
standard Perl license text.

Extra fixes:

  • Added use warnings to Expat.pm (the namespace() and eq_name()
    methods already had local no warnings 'numeric' blocks)
  • Added provides to META_MERGE in Makefile.PL, using dynamic version
    extraction via MM->parse_version() to avoid hardcoding

Experimental fixes:

  • Added SECURITY.md with vulnerability reporting contact
  • Added CONTRIBUTING.md with contribution guidelines

Regenerated README.md (from updated POD) and MANIFEST.

Testing

Full test suite passes (make test). Verified META provides appear
correctly in generated MYMETA.json.


Quality Report

Changes: 7 files changed, 265 insertions(+), 3 deletions(-)

Code scan: clean

Tests: passed (OK)

Branch hygiene: clean

Generated by Kōan post-mission quality pipeline

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.40%. Comparing base (4ee8e6f) to head (ac4856b).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #267   +/-   ##
=======================================
  Coverage   76.40%   76.40%           
=======================================
  Files           1        1           
  Lines        1102     1102           
  Branches      346      346           
=======================================
  Hits          842      842           
  Misses         52       52           
  Partials      208      208           
Flag Coverage Δ
perl 76.40% <ø> (ø)
xs 76.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- Add =head1 LICENSE section to Parser.pm (fixes has_license_in_source_file
  and has_known_license_in_source_file)
- Add META provides section to Makefile.PL with dynamic version extraction
  (fixes meta_yml_has_provides)
- Add SECURITY.md with vulnerability reporting contact (fixes
  has_security_doc and security_doc_contains_contact)
- Add CONTRIBUTING.md with contribution guidelines (fixes
  has_contributing_doc)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@toddr-bot toddr-bot force-pushed the koan.toddr.bot/fix-kwalitee-issues branch from f3a89bf to ac4856b Compare April 23, 2026 13:31
@toddr toddr marked this pull request as ready for review April 23, 2026 13:31
@toddr toddr merged commit 498eb95 into main Apr 23, 2026
36 checks passed
@toddr toddr deleted the koan.toddr.bot/fix-kwalitee-issues branch April 23, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants