Address CPANTS Kwalitee issues#267
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #267 +/- ##
=======================================
Coverage 76.40% 76.40%
=======================================
Files 1 1
Lines 1102 1102
Branches 346 346
=======================================
Hits 842 842
Misses 52 52
Partials 208 208
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Add =head1 LICENSE section to Parser.pm (fixes has_license_in_source_file and has_known_license_in_source_file) - Add META provides section to Makefile.PL with dynamic version extraction (fixes meta_yml_has_provides) - Add SECURITY.md with vulnerability reporting contact (fixes has_security_doc and security_doc_contains_contact) - Add CONTRIBUTING.md with contribution guidelines (fixes has_contributing_doc) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
f3a89bf to
ac4856b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Address all 7 failing CPANTS Kwalitee metrics identified at
https://cpants.cpanauthors.org/release/TODDR/XML-Parser-2.57
Why
CPANTS Kwalitee scores affect distribution discoverability and signal
quality to downstream users. The core metric (
has_license_in_source_file)directly impacts the Kwalitee score.
How
Core fix: Added
=head1 LICENSEsection to Parser.pm with thestandard Perl license text.
Extra fixes:
use warningsto Expat.pm (thenamespace()andeq_name()methods already had local
no warnings 'numeric'blocks)providesto META_MERGE in Makefile.PL, using dynamic versionextraction via
MM->parse_version()to avoid hardcodingExperimental fixes:
Regenerated README.md (from updated POD) and MANIFEST.
Testing
Full test suite passes (
make test). Verified META provides appearcorrectly in generated MYMETA.json.
Quality Report
Changes: 7 files changed, 265 insertions(+), 3 deletions(-)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline