Adopt the shared docs-check workflow - #52
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts the reusable
docs-checkworkflow from lentago/shared-workflows#28, which resolves relative markdown links across the repo's git-tracked markdown and fails on genuinely broken ones.The motivation is lentago/.github#57: documentation is most of what the fleet ships, and renames and removals — its most common change class — are exactly what silently break relative links. The evidence there was a broken image on a public README that survived a deliberate rename audit, because nothing verified it.
The workflow is deliberately not path-filtered. It is built to serve as a required status check, and a required check whose workflow never triggers is held "Expected" forever and deadlocks every non-matching PR, per the standing rule in
fleet-ops/required-checks.json. The checker is cheap and skips fast when no markdown changed.Two link classes are skipped by rule rather than by hand-maintained ignore lists — the two that accounted for 237 of the 240 raw failures in the fleet-wide scan: site-absolute router routes, which an Astro/Starlight router resolves at build time, and links that escape the repo root, which is GitHub's
../../issues/Nnavigation convention and can never point at a tracked file. This repo needs no additionalignoreentries: it was scanned with the checker before this PR was opened and reports clean.Part of a fleet-wide rollout; the matching
required-checks.jsonmapping follows as a separate change in the.githubmeta-repo once the context name is observed off a live check-run.