[basic.indet] Convert reference to [conv.lval] into note#7046
Merged
Conversation
eisenwave
force-pushed
the
circular-erroneous-reference
branch
from
efeb055 to
22dd6c5
Compare
Contributor
|
Originally (as per P2795R5) the reference was indeed meant to refer to the potential UB is the erroneous value is not valid. However, that wording was changed by https://cplusplus.github.io/CWG/issues/2899.html, and now the connection isn't as clear anymore. I agree that the note is helpful in making that connection. @jensmaurer? |
jensmaurer
requested changes
Nov 3, 2025
eisenwave
force-pushed
the
circular-erroneous-reference
branch
from
22dd6c5 to
02d149f
Compare
jensmaurer
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7045.
It is unclear what the purpose of
erroneous value~\iref(conv.lval}is here. [conv.lval| is not the subclause which defines "erroneous value" but this cross-reference makes it look like it is. This is especially nonsensical given that [conv.lval] cross-references back to [basic.indet], making this a circular reference.I assume that the intent here is to draw some extra attention to lvalue-to-rvalue conversion for specific erroneous values. Therefore, I have turned this into a note.
Alternatively, we could also eliminate the
\irefcompletely and leave everything as is otherwise.Also fixes #7715