Skip to content

[func.wrap.ref.class] Rename Args to ArgTypes#7575

Closed
steve-downey wants to merge 1 commit into
cplusplus:mainfrom
steve-downey:argtype-functionref
Closed

[func.wrap.ref.class] Rename Args to ArgTypes#7575
steve-downey wants to merge 1 commit into
cplusplus:mainfrom
steve-downey:argtype-functionref

Conversation

@steve-downey

Copy link
Copy Markdown
Contributor

There is no definition of Args in scope for function_ref. Moving the exposition only members out of the descriptive text brought with it the undefined template argument. Rename to ArgTypes.

@tkoeppe

tkoeppe commented Mar 17, 2025

Copy link
Copy Markdown
Contributor

Thanks! Could you kindly reword the commit message according to https://github.com/cplusplus/draft/wiki/Commit-message-format#editorial-commits and force-push?

@tkoeppe

tkoeppe commented Jun 17, 2025

Copy link
Copy Markdown
Contributor

@steve-downey: Ping :-)

@steve-downey

Copy link
Copy Markdown
Contributor Author

Ack. Will fix.

There is no definition of Args in scope for function_ref. Moving the exposition
only members out of the descriptive text brought with it the undefined template
argument. Rename to ArgTypes, the name used for the template parameter.
@steve-downey steve-downey force-pushed the argtype-functionref branch from e3ba60b to 8065cde Compare June 22, 2025 10:00
@steve-downey steve-downey changed the title Rename Args to ArgTypes, which is defined [func.wrap.ref.class] Rename Args to ArgTypes Jun 22, 2025
@eisenwave eisenwave added the P1-Important Misapplication of paper, malformed code, internal inconsistencies label Nov 6, 2025
@eisenwave

eisenwave commented Nov 6, 2025

Copy link
Copy Markdown
Member

@tkoeppe @jwakely this PR is almost an exact duplicate of #8219. It is making slightly more minimal changes.

Should we close this? Jonathan already approved the other one.

@tkoeppe

tkoeppe commented Nov 6, 2025

Copy link
Copy Markdown
Contributor

Yes, good call. @steve-downey Let's continue the discussion in the other PR.

@tkoeppe tkoeppe closed this Nov 6, 2025
@tkoeppe tkoeppe removed the P1-Important Misapplication of paper, malformed code, internal inconsistencies label Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants